Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming CMake variables / preprocessor variables to use common prefix #32

Closed
bacusters opened this issue Oct 11, 2020 · 0 comments · Fixed by #61 · May be fixed by #30
Closed

Renaming CMake variables / preprocessor variables to use common prefix #32

bacusters opened this issue Oct 11, 2020 · 0 comments · Fixed by #61 · May be fixed by #30
Assignees
@aniketmitra001
Labels
enhancement New feature or request
Projects
Release v1.0

Comments

@bacusters
Copy link
Collaborator

To avoid possible clashes with other libraries, I think it would be nice if we prefix MoveTk-specific CMake variables/ preprocessor variables with a common suffix such as MOVETK_. For me as a CMake gui user, this has the additional benefit that all MoveTk related CMake variables would be grouped.
@bacusters bacusters added the enhancement New feature or request label Oct 11, 2020
@aniketmitra001 aniketmitra001 self-assigned this Oct 11, 2020
@aniketmitra001 aniketmitra001 added this to To do in Release v1.0 via automation Oct 11, 2020
@aniketmitra001 aniketmitra001 linked a pull request Oct 11, 2020 that will close this issue
isolate dependencies #30
Open
@bacusters bacusters mentioned this issue Oct 4, 2022
Merged
@bacusters bacusters moved this from To do to Review in progress in Release v1.0 Oct 13, 2022
Release v1.0 automation moved this from Review in progress to Done Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aniketmitra001 aniketmitra001

Labels
enhancement New feature or request
Projects
Release v1.0
  
Done
Milestone
No milestone
2 participants
@aniketmitra001 @bacusters