Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming for geometric objects #64

Open
bacusters opened this issue Nov 28, 2022 · 0 comments
Open

Naming for geometric objects #64

bacusters opened this issue Nov 28, 2022 · 0 comments
Labels
question Further information is requested

Comments

@bacusters
Copy link
Collaborator

In our kernels, we name everything prefixed with Movetk e.g. MovetkPoint, MovetkLine. This prefix, however, does not really add any value. Would it make sense to simply rename them to Point, Line etc.? This makes using movetk with user defined kernels perhaps easier, since they do not need to use the prefix.

In addition, it may be convenient to add aliases for the geometric objects in the movetk::geom namespace, e.g.

template<typename Kernel>
using Point = typename Kernel::Point; //or MovetkPoint, if we decide not to remove the prefix

This makes using these types easier, then you can do movetk::geom::Point<Kernel> instead of typename Kernel::Point. This is similar to how CGAL approaches geometric objects.

@bacusters bacusters added the question Further information is requested label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant