Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During Jingle A/V RTP calls, Movim is not building extmap attribute correctly #1213

Closed
goffi-contrib opened this issue May 26, 2023 · 1 comment
Assignees
Labels

Comments

@goffi-contrib
Copy link

goffi-contrib commented May 26, 2023

While doing a RTP call, Movim being the initiator, if the other peer send XEP-0294 <rtp-hdrext> elements like those:

<rtp-hdrext xmlns="urn:xmpp:jingle:apps:rtp:rtp-hdrext:0" id="1" uri="urn:ietf:params:rtp-hdrext:ssrc-audio-level" senders="both"/>
<rtp-hdrext xmlns="urn:xmpp:jingle:apps:rtp:rtp-hdrext:0" id="3" uri="urn:ietf:params:rtp-hdrext:sdes:mid" senders="both"/>

Movim convert it to following SDP:

a=extmap:1 both urn:ietf:params:rtp-hdrext:ssrc-audio-level
a=extmap:3 both urn:ietf:params:rtp-hdrext:sdes:mid

This is invalid and result in failed call:

Reference: https://datatracker.ietf.org/doc/html/rfc8285#section-8

Tested with Movim v0.21rc7

@edhelas edhelas added the bug label May 27, 2023
@edhelas edhelas self-assigned this May 27, 2023
@edhelas
Copy link
Member

edhelas commented May 28, 2023

Fixed in b5b7aa0

@edhelas edhelas closed this as completed May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants