Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movim is incorrectly generating XEP-0339 <source> element #1214

Closed
goffi-contrib opened this issue May 26, 2023 · 0 comments
Closed

Movim is incorrectly generating XEP-0339 <source> element #1214

goffi-contrib opened this issue May 26, 2023 · 0 comments
Assignees
Labels

Comments

@goffi-contrib
Copy link

goffi-contrib commented May 26, 2023

During a call where Movim is the initiator, it convert the following SDP ssrc attributes for the video stream:

a=ssrc:134219770 cname:{8c7db19c-9153-48f2-b62b-c1042bc76bbd}
a=ssrc:1998259287 cname:{8c7db19c-9153-48f2-b62b-c1042bc76bbd}

to following XEP-0339 elements:

<source xmlns="urn:xmpp:jingle:apps:rtp:ssma:0" ssrc="134219770">
  <parameter value="{8c7db19c-9153-48f2-b62b-c1042bc76bbd}" name="cname"/>
  <parameter value="{8c7db19c-9153-48f2-b62b-c1042bc76bbd}" name="cname"/>
</source>

Incorrectly merging the parameters and discarding the second source. This is incorrect, and it should be instead:

<source xmlns="urn:xmpp:jingle:apps:rtp:ssma:0" ssrc="134219770">
  <parameter value="{8c7db19c-9153-48f2-b62b-c1042bc76bbd}" name="cname"/>
</source>
<source xmlns="urn:xmpp:jingle:apps:rtp:ssma:0" ssrc="1998259287">
  <parameter value="{8c7db19c-9153-48f2-b62b-c1042bc76bbd}" name="cname"/>
</source>

Accidentally, this make the call work with Conversations which incorrectly refuse multiple sources, but this is a bug a ignore the retransmission source, which degrades the call quality.

Tested with Movim v0.21rc7

Note: there is a bug in Conversations preventing the call to work with multiple sources: https://codeberg.org/iNPUTmice/Conversations/issues/58

@edhelas edhelas added the bug label May 27, 2023
@edhelas edhelas self-assigned this May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants