You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Today I used patch-package to patch react-native-logs@3.0.3 for the project I'm working on.
Running tsc on my project resulted in the following errors:
node_modules/react-native-logs/src/index.ts:465:3 - error TS1205: Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'.
465 transportFunctionType,
~~~~~~~~~~~~~~~~~~~~~
node_modules/react-native-logs/src/index.ts:466:3 - error TS1205: Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'.
466 configLoggerType,
~~~~~~~~~~~~~~~~
Found 2 errors.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
For whatever reason, tsc decided to still run its checks on the react-native-logs/src folder, despite node_modules being excluded in tsconfig.json and despite any changes I made to try and get it to ignore it.
From what I gather, the two solutions were to either enable skipLibCheck (which didn't seem to help) or turning off isolateModules (which I would rather avoid).
I eventually settled on patch-package with the following patch which seems to solve my problem:
I don't know if there are any hidden implications to this change (maybe specific TS version incompatibility?), so I'd love to know if there are.
But feel free to reject this suggestion if that is the case.
Hi! 馃憢
Firstly, thanks for your work on this project! 馃檪
Today I used patch-package to patch
react-native-logs@3.0.3
for the project I'm working on.Running
tsc
on my project resulted in the following errors:For whatever reason,
tsc
decided to still run its checks on thereact-native-logs/src
folder, despitenode_modules
being excluded intsconfig.json
and despite any changes I made to try and get it to ignore it.From what I gather, the two solutions were to either enable
skipLibCheck
(which didn't seem to help) or turning offisolateModules
(which I would rather avoid).I eventually settled on
patch-package
with the following patch which seems to solve my problem:I don't know if there are any hidden implications to this change (maybe specific TS version incompatibility?), so I'd love to know if there are.
But feel free to reject this suggestion if that is the case.
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: