-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for nested layouts #2
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 5 +3
Lines 36 68 +32
Branches 9 15 +6
=====================================
+ Hits 36 68 +32
Continue to review full report at Codecov.
|
9456969
to
3ac0e7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor docs tweaks
3ac0e7a
to
ae6f62f
Compare
BREAKING CHANGE: the API has greatly changed, please check the README
ae6f62f
to
f50b88a
Compare
@zebateira thanks for the review. I'm not sure if I should rename |
Hm, I don't have a strong opinion on it, but I think that leaving it as is |
40c749d
to
0102a1a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 5 +3
Lines 36 68 +32
Branches 9 15 +6
=========================================
+ Hits 36 68 +32
Continue to review full report at Codecov.
|
README.md
Outdated
|
||
Type: `ReactElement` or `function` | ||
|
||
In simple cases, you may defined a "static" layout tree, like so: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have defined => you may have defined
0102a1a
to
67136e0
Compare
BREAKING CHANGE: the API has greatly changed, please check the README