Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work inside workers threads #124

Closed
luizfelipe94 opened this issue Aug 6, 2019 · 5 comments · Fixed by #127
Closed

Does not work inside workers threads #124

luizfelipe94 opened this issue Aug 6, 2019 · 5 comments · Fixed by #127

Comments

@luizfelipe94
Copy link

I am trying to use execa by running code in worker threads, and it is generating the TypeError error [ERR_WORKER_UNSUPPORTED_OPERATION]: process.chdir () is not supported in workers.

process.chdir(cwd)
@ehmicky ehmicky mentioned this issue Oct 5, 2019
Closed
@ehmicky
Copy link
Contributor

ehmicky commented Oct 5, 2019 •
edited

Related execa issue: sindresorhus/execa#357

@satazor
Copy link
Contributor

satazor commented Oct 5, 2019

Seems easily solvable by adding a try catch just like the one we are doing above. Care to do a PR?

@ehmicky
Copy link
Contributor

ehmicky commented Oct 5, 2019

I can do that, but I don't know if I would have time to add a unit test since I'm not familiar with the test setup yet. Would it be ok to send PR without a unit test for this?

@satazor
Copy link
Contributor

satazor commented Oct 5, 2019

Yep!

@ehmicky ehmicky mentioned this issue Oct 6, 2019
Merged
@ehmicky
Copy link
Contributor

ehmicky commented Oct 6, 2019

Done at #127.

@fannheyward fannheyward mentioned this issue Dec 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support worker threads
3 participants
@satazor @ehmicky @luizfelipe94