Add kill function to spawn object

[kentcdodds]

Originally I wanted to extract this as a separate module, but I think it actually makes most sense to simply add it to cross-spawn itself. Would you be interested? The win32 version of the function would be:

function kill() {
  crossSpawn("taskkill", ["/F", "/T", "/PID", this.pid])
}

And the posix:

const getDescendentProcessInfo = require("ps-tree")

function kill() {
    getDescendentProcessInfo(this.pid, (err, descendent) => {
        if (err) {
            return
        }

        descendent.forEach(({PID: pid}) => {
            try {
                process.kill(pid)
            }
            catch (_err) {
                // ignore.
            }
        })
    })
}

Would you be willing to accept a PR for this?

cc @mysticatea

[satazor]

I think this is out of the scope of this project and should be in its own module.

Thanks anyway.

[kentcdodds]

cross-spawn-with-kill coming soon to an npm near you :)
cc @mysticatea

[hemanth]

heh heh I came here exactly for this!

[kentcdodds]

It's a thing now :) https://github.com/kentcdodds/cross-spawn-with-kill

[satazor]

Cool

[Igmat]

@kentcdodds, thanks a lot for your package - it saves my day.
@satazor, are you sure that kill() for child processes is out of scope for your package? I've spent two days trying to figure out why my integration test doesn't work, cause I don't even thought that problem could be in your package. I have used your package in same manner as node's default spawn function and used types from node for it. Could you please, rethink your decision and accept a PR for it, or may be add mention of this behavior in readme with link to cross-spawn-with-kill?

[MohamedLamineAllal]

@satazor What's wrong with accepting the PR ? the function is pretty handy.

[satazor]

You may read the thread starting at this comment on why it didn’t make it: #44 (comment)