feat: add timeout option to prompt (Close #37) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 58 62 +4
Branches 11 12 +1
=========================================
+ Hits 58 62 +4
Continue to review full report at Codecov.
|
|
I had to remove the prompt timeout count as it was badly clearing the input line |
satazor
requested changes
Oct 2, 2020
satazor
reviewed
Oct 5, 2020
satazor
reviewed
Oct 6, 2020
|
@satazor anything else you would like before merging? |
satazor
approved these changes
Oct 7, 2020
|
That’s all! Thank you. I will release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the timeout function
I was not able to emulate Ctrl+C to catch line 27 of prompt.js, if you have an idea, I'll update the test.
The options.timeout is in seconds, and you can use a {timeout} variable in the prompt to display, the remaining seconds before timeout.
I had to add the --runInBand to avoid interference on process.stdin/out by several tests, as timeout tests take several seconds.