-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links must have discernible text #8
Comments
Fixed this my own! Changed to html mode because it was easier to edit and edited piwigo-random-backend.php file at the end. Pagespeed now ok from this part. Did little extra and added And added There should be and Image elements do not have explicit width and height attributes too, but I have no idea or skills to get that done. Also these should do to javascript mode too. |
Can you send a pull-request with all these? |
Hmm. Create new Pull-request is disabled for me. And I`m not very good with this Github thing and coding, not sure that it is done right. |
Did something in git hub but I´m sure I didn´t do it right. |
Edit: Now got my browser in english for better description about issues from Pagespeed. And there is another issue too.
Testing in Google page speed Accessibility results drops because of this thing!
Pagespeed report about this: " Links do not have a discernible name
Link text (and alternate text for images, when used as links) that is discernible, unique, and focusable improves the navigation experience for screen reader users."
Second issue that I found:
"Image elements do not have explicit width and height Set an explicit width and height on image elements to reduce layout shifts and improve CLS."
The text was updated successfully, but these errors were encountered: