Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small issues #32

Closed
kiwih opened this issue Aug 25, 2022 · 2 comments
Closed

Small issues #32

kiwih opened this issue Aug 25, 2022 · 2 comments
Assignees

Comments

@kiwih
Copy link

kiwih commented Aug 25, 2022

Thanks for the great repo! Just a couple of issues:

  • the openAI root url should not include the 'v1'
  • docker-compose could really be renamed to docker compose in the README as docker-compose is now deprecated
  • Issue with config files for setups with >2 GPUs.
moyix added a commit that referenced this issue Aug 29, 2022
`docker-compose` is now `docker compose` so don't call it `docker-compose` any more. See #32
@moyix
Copy link
Collaborator

moyix commented Aug 29, 2022

The openAI root url should not include the 'v1'

This turns out to be an issue if you are using an older version of the OpenAI Python library -- with the most recent one, the API root URL should contain the v1.

docker-compose could really be renamed to docker compose in the README as docker-compose is now deprecated

Good point. Fixed.

Issue with config files for setups with >2 GPUs.

Working on this :) I added a config file generator to the repo in the converter directory, I just need to integrate it into setup.sh now.

@moyix moyix self-assigned this Aug 29, 2022
@kiwih
Copy link
Author

kiwih commented Sep 6, 2022

Looks good, thanks!

@kiwih kiwih closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants