-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files in 'hidden' directories are still rendered #12
Comments
Cross platforms compatibility is really a pain in the ass 😂, I will fix it in the next release version. |
That's true. ^^ Could you also change the glob value from "!" + path.posix.join(this.base, `**/_**/*`) to "!" + path.posix.join(this.base, `**/_**/**/*`) since then it would be possible creating folders in hidden directories without the need of another underscore on each sub-folder... Like the following structure:
Without the changed glob, the sub-folders are rendered (at least on Windows). I also tried the front-matter header today, and noticed a small bug (?): I guess this line should be |
Fixed in |
Hello,
I ran into the issue that your extension also rendered files within a
_*
directory, and I guess that's an Windows only (with node.js v18.0.0) issue due to the path separator\
passed to globby. At least I could fix it by adding the path replacement regex, on the patterns, on the remaining 2 ones as well:I guess this should be better placed directly in the constructor, where
this.base
gets assigned.Thanks for your extension.
The text was updated successfully, but these errors were encountered: