This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Initial error refactoring (make errors less HTTP specific) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| callback( | ||
| new Errors.InvalidEntrypoint('no useful location information found') |
There was a problem hiding this comment.
Just a thought.. Maybe you'd save a bit of time on startup work if you instead lazy-init'd the errors? E.g., make the folllowing callable:
new Error('InvalidEntrypoint, 'no useful location information found')
I suppose the current implementation might be a bit more cleaner though.
There was a problem hiding this comment.
For internal CalDAV use (and use on the main thread) I would like instanceof to work? Make sense?
|
@lightsofapollo Looks good to me! 👍 |
KevinGrandon
added a commit
that referenced
this pull request
May 7, 2013
Initial error refactoring (make errors less HTTP specific)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.