Bug 971495 - [System2] Instantiable HardwareButtons +shepherd #16280
Conversation
| @@ -48,272 +48,307 @@ | |||
| // | |||
| 'use strict'; | |||
|
|
|||
There was a problem hiding this comment.
To be consistent:
(function(window) {
function HB() { ... };
window.HB = HB;
}(this));
There was a problem hiding this comment.
I've been using the exports object instead, which we use in a few other files, can we do that instead?
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/ttlview.js#L4
There was a problem hiding this comment.
Ouch, 3 patterns from 3 people O_o
I don't like what @alivedise did coz it's simply redefining window with a non-useful closure. exports probably make more sense.
There was a problem hiding this comment.
Yeah, exports make sense. I will file a bug to change the pattern to fit it of all modules in system.
There was a problem hiding this comment.
Also I was having trouble getting JSHint to work when passing this into the closure. I would like this to work, but could not get it to pass jshint. If you have some magic, please let me know :)
Bug 971495 - [System2] Instantiable HardwareButtons, r=alive
No description provided.