This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 971565 - [System2] Instantiable Title #16287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EragonJ
commented
Feb 14, 2014
EragonJ
commented
- update test
- update bootstrap.js
| element: document.getElementById('statusbar-title'), | ||
| /** | ||
| * Title handle logic for the global title in the statusbar | ||
| * @class Title |
- update test - update bootstrap.js
EragonJ
added a commit
that referenced
this pull request
Feb 17, 2014
Bug 971565 - [System2] Instantiable Title
|
Thanks alive ! |
| @@ -1,11 +1,13 @@ | |||
| 'use strict'; | |||
| /* global AppWindow, AppWindowManager, | |||
| MocksHelper, MockL10n, Rocketbar, Title */ | |||
| MocksHelper, MockL10n, Rocketbar, Title, requireApp, mocha, suite, test, | |||
There was a problem hiding this comment.
nit: most of these standard testing globals should already be defined in the .jshintrc file. Do we really need them?
There was a problem hiding this comment.
! There may have some problems on my side because my linter would alarm this ! I will check .jshintrc and change this back ! Thanks Kevin !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.