Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate template-manifest.json from "applications" to "browser_specific_settings" #27

Closed
rpl opened this issue Oct 25, 2022 · 3 comments

Comments

@rpl
Copy link

rpl commented Oct 25, 2022

I noticed this as part of reviewing https://phabricator.services.mozilla.com/D160057 (part of Bug 1797050) and so I thought to file this followup upfront:

In MV3 we plan to fully deprecate "applications" from the manifest.json, in favor from the other alias "browser_specific_settings" (which we support from quite a long time and so it should be backward compatible enough also with older Firefox versions) and so we may change the template-manifest.json part of this repo to make sure we migrated the adb addon away from it ahead to its future deprecation.

The diff to apply the change describe above would look like in the following diff:

diff --git a/extension/template-manifest.json b/extension/template-manifest.json
index 8888843..f0a47ab 100644
--- a/extension/template-manifest.json
+++ b/extension/template-manifest.json
@@ -4,7 +4,7 @@
   "author": "Mozilla & Android Open Source Project",
   "version": "@@VERSION@@",
   "description": "An extension providing ADB binaries for Android remote debugging in Firefox DevTools. May be automatically installed when using about:debugging.",
-  "applications": {
+  "browser_specific_settings": {
     "gecko": {
       "id": "adb@mozilla.org",
       "strict_min_version": "64.0a1",

NOTE: the template-updates.json file also includes an "applications" property which SHOULD NOT be changed to "browser_specific_settings", for that one Firefox doesn't yet support any alias named "browser_specific_settings" and unfortunately its named and its format looks basically the same as the manifest.json one which may be confusing and so I'm calling it out explicitly in this issue to make sure we don't mistakenly change that one along with the manifest.json one.

@juliandescottes
Copy link
Collaborator

Thanks for filing @rpl ! Do you know we can expect applications to be fully deprecated. Just to know how urgent it is for us to release an updated version of the extension

@willdurand
Copy link
Member

@juliandescottes applications won't work in MV3, in MV2 it will likely be still allowed. It isn't urgent I think.

@willdurand
Copy link
Member

see #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants