Make update URL configurable. #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I suggest turning whitespace off in the diff: https://github.com/mozilla-iot/gateway/pull/776/files?w=1 |
This is the first step required for WebThingsIO#697.
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
==========================================
+ Coverage 78.85% 78.86% +0.01%
==========================================
Files 85 85
Lines 3457 3459 +2
Branches 452 452
==========================================
+ Hits 2726 2728 +2
Misses 672 672
Partials 59 59
Continue to review full report at Codecov.
|
hobinjk
approved these changes
Mar 21, 2018
| } | ||
| fetch(config.get('updateUrl'), | ||
| {headers: {'User-Agent': `mozilla-iot-gateway/${pkg.version}`}}) | ||
| .then(res => { |
There was a problem hiding this comment.
nit: should be consistent with line 13 (which means it wouldn't have the extra indentation either)
hobinjk
reviewed
Mar 21, 2018
tools/check-for-update.js
Outdated
| @@ -1,61 +1,63 @@ | |||
| const config = require('config'); | |||
| const exec = require('child_process').exec; | |||
| const fetch = require('node-fetch'); | |||
| const fs = require('fs'); | |||
There was a problem hiding this comment.
unused import causing tests to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step required for #697.