Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep query parameters when redirecting for login. #783

Merged
merged 1 commit into from Mar 23, 2018
Merged

Keep query parameters when redirecting for login. #783

merged 1 commit into from Mar 23, 2018

Conversation

mrstegeman
Copy link
Contributor

Fixes #779

@mrstegeman mrstegeman requested a review from hobinjk March 21, 2018 16:41
@ghost ghost assigned mrstegeman Mar 21, 2018
@ghost ghost added the review label Mar 21, 2018
@codecov-io
Copy link

codecov-io commented Mar 21, 2018 •
edited

Codecov Report

Merging #783 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #783   +/-   ##
=======================================
  Coverage   78.86%   78.86%           
=======================================
  Files          85       85           
  Lines        3459     3459           
  Branches      452      452           
=======================================
  Hits         2728     2728           
  Misses        672      672           
  Partials       59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 466ca7c...f3ba293. Read the comment docs.

@mrstegeman
Copy link
Contributor Author

@hobinjk does this fix it for you?

hobinjk
hobinjk approved these changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@hobinjk hobinjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks! Tested locally and LGTM.

@mrstegeman mrstegeman merged commit 9446a0c into WebThingsIO:master Mar 23, 2018
@ghost ghost removed the review label Mar 23, 2018
@mrstegeman mrstegeman deleted the redirect-with-params branch March 23, 2018 12:43
@mrstegeman mrstegeman added this to Done in WebThings Gateway Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobinjk hobinjk hobinjk approved these changes

Assignees

@mrstegeman mrstegeman

Labels
None yet
Projects
WebThings Gateway
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrstegeman @codecov-io @hobinjk