Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch websocket error. #826

Merged
merged 1 commit into from Apr 3, 2018

Conversation

sogaani
Copy link
Contributor

@sogaani sogaani commented Apr 3, 2018

The Gateway exits, when property change and websocket close occur at the same time.

@codecov-io
Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #826 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
- Coverage   77.14%   77.13%   -0.01%     
==========================================
  Files          87       87              
  Lines        3763     3766       +3     
  Branches      501      502       +1     
==========================================
+ Hits         2903     2905       +2     
- Misses        788      789       +1     
  Partials       72       72
Impacted Files Coverage Δ
src/controllers/things_controller.js 82.5% <83.33%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bce215b...f963d38. Read the comment docs.

@mrstegeman mrstegeman merged commit d5f861f into WebThingsIO:master Apr 3, 2018
@sogaani sogaani deleted the catch-websocket-error branch April 11, 2018 05:59
@mrstegeman mrstegeman added this to Done in WebThings Gateway Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants