Handle serviceDown events. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an mDNS service goes down, remove the linked device. If a service does not send out a notification that it's going down, it will automatically expire at the TTL in the service record, which tends to be quite short. Fixes WebThingsIO#54
ghost
assigned 
hobinjk
approved these changes
Aug 27, 2018
|
|
||
| if (this.ws.readyState === WebSocket.OPEN) { | ||
| this.ws.close(); | ||
| } | ||
|
|
||
| this.ws = null; | ||
| // Allow the cleanup code in createWebsocket to handle shutdown |
There was a problem hiding this comment.
The cleanupAndReopen code should be updated to null this.ws then for paranoia's sake.
There was a problem hiding this comment.
Fair point. Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an mDNS service goes down, remove the linked device. If a
service does not send out a notification that it's going down, it
will automatically expire at the TTL in the service record, which
tends to be quite short.
Fixes #54