Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Incompatible glean versions #11276

Closed
agi opened this issue Nov 16, 2021 · 1 comment
Closed

Incompatible glean versions #11276

agi opened this issue Nov 16, 2021 · 1 comment
Labels
🏗️ build Build system, gradle, configuration <engine-gecko> Component: browser-engine-gecko <glean> Component: service-glean (New telemetry SDK)

Comments

@agi
Copy link
Contributor

agi commented Nov 16, 2021

Over at matrix#glean, mcomella found an inconsistency in the glean dependency:

service-glean depends on glean-native 42.0.1 and browser-engine-gecko depends on GeckoView 96.0.20211115093917 which depends on 42.1.0

This should not build, but it does because our resoultion strategy prefers GeckoView: https://searchfox.org/mozilla-mobile/source/android-components/build.gradle#87-93

We shouldn't rely on the resolution strategy since outside consumers don't have that and instead have matching versions across the codebase. Will post a patch soon.

┆Issue is synchronized with this Jira Task

@pocmo pocmo added <engine-gecko> Component: browser-engine-gecko <glean> Component: service-glean (New telemetry SDK) 🏗️ build Build system, gradle, configuration labels Nov 17, 2021
@csadilek
Copy link
Contributor

The fix for this landed, and the link above is actually pointing to it now. Original problem was:

resolutionStrategy.capabilitiesResolution.withCapability("org.mozilla.telemetry:glean-native") {
def toBeSelected = candidates.find { it.id instanceof ModuleComponentIdentifier && it.id.module.contains('geckoview') }
if (toBeSelected != null) {
select(toBeSelected)
}
because 'use GeckoView Glean instead of standalone Glean'

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🏗️ build Build system, gradle, configuration <engine-gecko> Component: browser-engine-gecko <glean> Component: service-glean (New telemetry SDK)
Projects
None yet
Development

No branches or pull requests

3 participants