Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Resizing BrowserToolbar buttons #741

Closed
severinrudie opened this issue Sep 10, 2018 · 5 comments
Closed

Resizing BrowserToolbar buttons #741

severinrudie opened this issue Sep 10, 2018 · 5 comments
Assignees
Labels
🌟 feature New functionality and improvements <toolbar> Components: browser-toolbar, concept-toolbar

Comments

@severinrudie
Copy link
Contributor

severinrudie commented Sep 10, 2018

We are setting up our toolbar by adding Actions to a BrowserToolbar, but have a requirement to change the size of the toolbar buttons. Is there any way to do this using the existing API? It seems that the ImageButtons are using each image's intrinsic size, so modifying a vector asset's size is an effective workaround, but we would rather not maintain multiple sets of icons at different sizes.

How would you suggest we approach this?

┆Issue is synchronized with this Jira Task

@mcomella
Copy link
Contributor

We also need to divorce the asset size from the touch target size.

@csadilek csadilek added the <toolbar> Components: browser-toolbar, concept-toolbar label Sep 12, 2018
@mcomella
Copy link
Contributor

It appears the buttons touch target's size themselves according to the toolbar content size (i.e. the height minus the padding) and the icons take their intrinsic size. Since our icons are the size we want and the touch target size we want is the size of the toolbar content, we've actually solved this problem.

@pocmo pocmo added the 🌟 feature New functionality and improvements label Sep 24, 2018
@mauryat
Copy link
Contributor

mauryat commented Aug 9, 2019

@NotWoods is this still valid? Can you assign it to me?

@NotWoods
Copy link
Contributor

NotWoods commented Aug 9, 2019

As far as I know this is still valid.

@data-sync-user data-sync-user changed the title Resizing BrowserToolbar buttons FNX3-22775 ⁃ Resizing BrowserToolbar buttons Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX3-22775 ⁃ Resizing BrowserToolbar buttons FNX2-18357 ⁃ Resizing BrowserToolbar buttons Aug 5, 2020
@st3fan st3fan changed the title FNX2-18357 ⁃ Resizing BrowserToolbar buttons Resizing BrowserToolbar buttons Aug 5, 2020
@pocmo
Copy link
Contributor

pocmo commented Feb 3, 2021

Looking through old issues and closing them if they are not applicable anymore.

Currently this is not needed and in the long-term we may look at moving components like this to Jetpack Compose.

@pocmo pocmo closed this as completed Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🌟 feature New functionality and improvements <toolbar> Components: browser-toolbar, concept-toolbar
Projects
None yet
Development

No branches or pull requests

6 participants