Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

onProgress only called with values 15 and 100 #8746

Closed
csadilek opened this issue Oct 19, 2020 · 3 comments
Closed

onProgress only called with values 15 and 100 #8746

csadilek opened this issue Oct 19, 2020 · 3 comments
Assignees
@csadilek
Labels
blocked Blocked pull requests and issues 🐞 bug Something isn't working <engine-gecko> Component: browser-engine-gecko performance Performance related issues
Projects
Performance, front-end roadmap

Comments

@csadilek
Copy link
Contributor

csadilek commented Oct 19, 2020 •
edited by data-sync-user

This is a regression in GeckoView 82/83: https://bugzilla.mozilla.org/show_bug.cgi?id=1672046

In 81 and before we would get additional onProgress events e.g. for 55 and 80.

Filing this as a placeholder to verify the fix once ready.

┆Issue is synchronized with this Jira Task
@csadilek csadilek added 🐞 bug Something isn't working <engine-gecko> Component: browser-engine-gecko blocked Blocked pull requests and issues labels Oct 19, 2020
@csadilek csadilek self-assigned this Oct 19, 2020
@csadilek
Copy link
Contributor Author

In addition this bug causes the progress bar to stick around at 15 longer than before because of pageShow events not being processed: https://searchfox.org/mozilla-central/source/mobile/android/modules/geckoview/GeckoViewProgress.jsm#391

@mcomella mcomella added this to Needs prioritization in Performance, front-end roadmap via automation Oct 19, 2020
@mcomella mcomella added the performance Performance related issues label Oct 19, 2020
@mcomella
Copy link
Contributor

Performance label: csadilek mentioned the perceived performance impact of this.

@mcomella mcomella moved this from Needs prioritization to Top 10 Inter-Team bugs in Performance, front-end roadmap Oct 21, 2020
@csadilek
Copy link
Contributor Author

This is fixed now and works in latest Fenix Nightly as well.

A-C: Android Components Sprint Planning automation moved this from 🚷 Blocked to 🏁 Done Oct 26, 2020
Performance, front-end roadmap automation moved this from Top 10 Inter-Team bugs to Done Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@csadilek csadilek

Labels
blocked Blocked pull requests and issues 🐞 bug Something isn't working <engine-gecko> Component: browser-engine-gecko performance Performance related issues
Projects
Performance, front-end roadmap
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csadilek @mcomella