Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Provide a way to exclude Glean from Fenix #10125

Closed
sysrqb opened this issue Apr 22, 2020 · 3 comments
Closed

Provide a way to exclude Glean from Fenix #10125

sysrqb opened this issue Apr 22, 2020 · 3 comments
Labels
feature request 🌟 New functionality and improvements Feature:Telemetry

Comments

@sysrqb
Copy link

sysrqb commented Apr 22, 2020

Why/User Benefit/User Problem

Build a "flavor" of Fenix without Glean. This is helpful for non-Mozilla builds of Fenix where the resulting browser has strict data-sharing (no telemetry) and networking requirements.

What/Requirements

Add a built-time control mechanism for excluding Glean. This could be a new build config property or a new build type.

Acceptance Criteria (how do I know when I’m done?)

Fenix builds/runs/doesn't-crash (and all of the unit tests pass, except for Glean-specific tests)

┆Issue is synchronized with this Jira Task

@sysrqb sysrqb added the feature request 🌟 New functionality and improvements label Apr 22, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 22, 2020
@sysrqb
Copy link
Author

sysrqb commented Apr 22, 2020

I got this working by adding a buildSrc Config paramter as a flag for toggling when Glean should be included as an implementation dependency or compileOnly dependency.

sysrqb@fd42637

This patch includes more than simply including/excluding Glean (such as hiding the Data Collection setting).

I'm looking for a way of doing this such that we can extend it to megazoid components, as well. The proposed patch only requires minimal code changes, and only introduces a dependency on BuildConfig.

I'm having trouble excluding source files in build.gradle (in particular, unit test files for testing Glean), but that's likely a separate issue.

Any feedback about improvements/suggestions and what you would consider accepting (or what you won't accept upstream), are all helpful.

@androidacy-user
Copy link

Personally anything that allows for a purely FOSS build, such as the current F-Droid edition I think is a great idea.

@eliserichards eliserichards added this to Triage in Feature Discovery Apr 23, 2020
@eliserichards eliserichards removed this from Inbox in Engineering triage Apr 23, 2020
@eliserichards eliserichards added Feature:Telemetry and removed needs:triage Issue needs triage labels Apr 23, 2020
@data-sync-user data-sync-user changed the title Provide a way to exclude Glean from Fenix FNX3-13661 ⁃ Provide a way to exclude Glean from Fenix Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13661 ⁃ Provide a way to exclude Glean from Fenix FNX-3300 ⁃ Provide a way to exclude Glean from Fenix Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-3300 ⁃ Provide a way to exclude Glean from Fenix FNX2-13076 ⁃ Provide a way to exclude Glean from Fenix Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX2-13076 ⁃ Provide a way to exclude Glean from Fenix Provide a way to exclude Glean from Fenix Aug 27, 2020
@csadilek
Copy link
Contributor

csadilek commented Jan 9, 2023

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1809318

Change performed by the Move to Bugzilla add-on.

@csadilek csadilek closed this as completed Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request 🌟 New functionality and improvements Feature:Telemetry
Projects
No open projects
Development

No branches or pull requests

4 participants