Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add a Startup Option to Specify the Client ID #124

Closed
Sdaswani opened this issue Aug 30, 2018 · 7 comments
Closed

Add a Startup Option to Specify the Client ID #124

Sdaswani opened this issue Aug 30, 2018 · 7 comments
Labels
feature request 🌟 New functionality and improvements Feature:Telemetry needs:ac Needs Android Component Work

Comments

@Sdaswani
Copy link

Sdaswani commented Aug 30, 2018

Why/User Benefit/User Problem

Automated and performance testing may skew our telemetry numbers, confusing us. We don't like to be confused!

What / Requirements

Add a Startup Option to Specify the Client ID . The Client ID would be used as the id for our telemetry calls.

Acceptance Criteria (how do I know when I’m done?)

I can start up Focus with a specified client id and that is what is reported in redash.

cc @mmccorks

┆Issue is synchronized with this Jira Task

@nojunpark
Copy link

Reminder that upon completion nimbledroid / google firebase upload should be checked.

@mcomella
Copy link
Contributor

This needs to change in components first: see mozilla-mobile/android-components#695

@pocmo
Copy link
Contributor

pocmo commented Sep 3, 2018

FYI: For UI tests on Firebase we only upload debug builds that do not send any telemetry. To Nimbledroid we upload Nightly and Release builds though.

@pocmo
Copy link
Contributor

pocmo commented Sep 3, 2018

Regarding mozilla-mobile/android-components#695:

If we add a startup option here then could this option just disable telemetry? Or do we want to actually upload the pings?

@Sdaswani
Copy link
Author

Sdaswani commented Sep 3, 2018

@pocmo my thought is we should still upload telemetry so we can run tests on the client as a 'black box', e.g., if the telemetry library breaks and becomes a substantial performance bottleneck, if we shut off telemetry during startup for performance builds we would never discover that issue.

@boek boek transferred this issue from mozilla-mobile/focus-android Dec 14, 2018
@boek boek pinned this issue Dec 14, 2018
@boek boek unpinned this issue Dec 14, 2018
@mcomella
Copy link
Contributor

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1514336 against glean.

@bbinto bbinto added the P2 Upcoming release label Jan 22, 2019
@bbinto bbinto added this to the Backlog milestone Jan 22, 2019
@vesta0 vesta0 removed P3 Some future sprint labels Mar 29, 2019
@vesta0 vesta0 modified the milestones: Backlog, Backlog (After MVP) Mar 29, 2019
@kbrosnan kbrosnan added Feature:Telemetry needs:ac Needs Android Component Work labels Apr 30, 2019
@vesta0 vesta0 added the feature request 🌟 New functionality and improvements label Jul 26, 2019
@vesta0 vesta0 removed this from the Feature Backlog milestone Jul 26, 2019
@vesta0 vesta0 added needs:group-triage and removed P2 Upcoming release labels Sep 28, 2019
@liuche
Copy link
Contributor

liuche commented Oct 1, 2019

We have so few QA release tests (manual) compared to our userbase, and this requires Glean work, so we're going to close this for now because it's not important. Can re-open if we start doing more automated, release tests.

@liuche liuche closed this as completed Oct 1, 2019
@data-sync-user data-sync-user changed the title Add a Startup Option to Specify the Client ID FNX2-16860 ⁃ Add a Startup Option to Specify the Client ID Aug 2, 2020
@data-sync-user data-sync-user changed the title FNX2-16860 ⁃ Add a Startup Option to Specify the Client ID FNX3-15360 ⁃ Add a Startup Option to Specify the Client ID Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15360 ⁃ Add a Startup Option to Specify the Client ID FNX-36 ⁃ Add a Startup Option to Specify the Client ID Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-36 ⁃ Add a Startup Option to Specify the Client ID FNX2-16860 ⁃ Add a Startup Option to Specify the Client ID Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16860 ⁃ Add a Startup Option to Specify the Client ID Add a Startup Option to Specify the Client ID May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request 🌟 New functionality and improvements Feature:Telemetry needs:ac Needs Android Component Work
Projects
None yet
Development

No branches or pull requests

9 participants