[Bug] Save to collection button displayed in private mode, when not in view in normal mode

[Diana-Rus]

Steps to reproduce

1. Have 9-11 tabs opened in normal browsing.
2. Have at least 2 tabs opened in private browsing.
3. Go on a tab in normal browsing.
4. Tap on tabs tray.
5. Enable the selection of tabs for collection in normal browsing.
6. Cancel the selection.
7. Go to private tabs tray.

Expected behavior

Only the opened tabs in private browsing are displayed. The "Save to collection" button is not displayed.

Actual behavior

The "Save to collection" button is displayed in tabs tray.

Device information

• Android device: Samsung Galaxy S9 (Android 8), Google Pixel 3XL (Android 9)
• Fenix version: Nightly 8/6

Note:

- Seems that when the "Save to collection" button is not in view, helps reproducing the issue.
EDIT: I might depend on how many tabs can be opened in the device's view from normal browsing tabs tray+1 and then proceeding with step 5 to 7 !!!

• In case no tabs are present in private mode and do the steps from 4 to 7,than the button is not displayed in private mode.
• in case there is one tab present and do the steps from 4 to 7,than the button is not displayed in private mode.
• In case you don't do step 5 in normal browsing and directly in private browsing than the issue does not reproduce.

GIF

┆Issue is synchronized with this Jira Task

[Diana-Rus]

Reproducible on Firefox Beta 80.0.0-beta.4 with the following devices:

• Samsung Galaxy S9 (Android 8) - the issue is reproducible only when having 9+ tabs opened.
• Samsung Galaxy Tab S3 (A8) - the issue is reproducible only when having 12+ tabs opened.
• Google Pixel 4 XL (Android 11) - the issue is reproducible only when having 12+ tabs opened.

It's a little bit strange because on some devices only from 12+ opened tabs the issue is reproducible, also please note that if changing from PB to Normal and then back to PB the save to collection disappears and it's displayed only the first time when reproducing the bug, making it an edge case.

For Samsung Galaxy Tab S3 (A8) sometimes the save to collection button appears only when switching a few times between Normal browsing and Private browsing.

Please take in consideration the following

Note:

• Seems that when the "Save to collection" button is not in view, helps reproducing the issue.

Based on the note, it depends on the device the number of tabs opened in normal browsing, in order to have "Save to collection" button not in view, when making the selection !!!

Reduced STR

1. Open multiple tabs(depending on the device height) in normal browsing and 2 tabs in PB.
2. Select few tabs in normal browsing.
3. Tap on the "x" button in order to cancel the selection.
4. Switch to PB from tabs tray.

[stale]

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.