Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

buildTranslationsArray runs as a side effect, isn't called directly #14175

Closed
NotWoods opened this issue Aug 25, 2020 · 1 comment
Closed

buildTranslationsArray runs as a side effect, isn't called directly #14175

NotWoods opened this issue Aug 25, 2020 · 1 comment
Labels
eng:build Build system, gradle, configuration eng:ready Ready for engineering wontfix

Comments

@NotWoods
Copy link
Contributor

NotWoods commented Aug 25, 2020 •
edited by data-sync-user

Rather than running when the task is run, buildTranslationsArray currently builds the array when the task is first created. It seems to be equivalent to just writing the code and having no task block at all. We should move this logic into doLast and run the task at the appropriate time.

┆Issue is synchronized with this Jira Task
@NotWoods NotWoods added the eng:build Build system, gradle, configuration label Aug 25, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 25, 2020
@ekager ekager added eng:ready Ready for engineering and removed needs:triage Issue needs triage labels Dec 18, 2020
@stale
Copy link

stale bot commented Jun 16, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 16, 2021
@stale stale bot closed this as completed Jun 23, 2021
@pascalchevrel pascalchevrel mentioned this issue Feb 2, 2024
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:build Build system, gradle, configuration eng:ready Ready for engineering wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NotWoods @ekager