Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Dark mode consistency - UI, initial loading content page color, reader view #16467

Closed
crisalis2 opened this issue Nov 9, 2020 · 2 comments
Closed
Labels
feature request 🌟 New functionality and improvements Feature:Themes Dark mode, light mode, private browsing mode

Comments

@crisalis2
Copy link

crisalis2 commented Nov 9, 2020

What is the user problem or growth opportunity you want to see solved?

When you use Firefox in dark mode you will have a dark UI which is a specific shade of gray and a loading content page color that is another different shade of gray (this was implemented very recently, see #6313). The shades don't match. If they matched, which is the change I suggest here, Firefox would look more consistent and clean.

Additionally, there's the reader view. You can manually set it to a dark background (by the way, I think the dark background should be automatically selected if the user is using dark mode in Firefox/Android). This dark background is yet another shade of gray different from UI's gray and loading content page's gray. I suggest this color too is unified with those of the UI and the loading page.

How do you know that this problem exists today? Why is this important?

Okay, this is not THAT important, but I see no reason why those three shades of gray should be different from each other. Most likely, they were implemented by different people in different moments, but if they were implemented at the same time in a more "unified" way I'm pretty sure they would have been the same color.
Also, I don't think this is too difficult to fix.

Who will benefit from it?

Dark mode users.

--

Additional pictures ilustrating the issue.

UI's gray.
Screenshot_20201109-232000_Firefox Nightly

Initial loading content page color (dark mode).
Screenshot_20201109-231715_Firefox Nightly

Reader view's dark background.
Screenshot_20201109-231906_Firefox Nightly

Edit:
There's also this other shade of gray from the tab switcher:
Screenshot_20201110-172419_Firefox Nightly

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 9, 2020
@BlindMoon38
Copy link

In regards to the Reader view following the app's theme, there's #3289

@sflorean sflorean added feature request 🌟 New functionality and improvements Feature:Themes Dark mode, light mode, private browsing mode and removed needs:triage Issue needs triage labels Jan 11, 2021
@csadilek
Copy link
Contributor

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1807088

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request 🌟 New functionality and improvements Feature:Themes Dark mode, light mode, private browsing mode
Projects
None yet
Development

No branches or pull requests

4 participants