Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Retrieve branding name and version from chrome priv JS (remote debugging) #2016

Closed
juliandescottes opened this issue Apr 25, 2019 · 7 comments
Labels
🐞 bug Crashes, Something isn't working, .. needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org P2 Upcoming release 🙅 waiting Issues that are blocked or has dependencies that are not ready wontfix

Comments

@juliandescottes
Copy link

juliandescottes commented Apr 25, 2019

For DevTools' remote debugging, we currently retrieve the browser name from the "chrome://branding/locale/brand.properties" string bundle, and the browser version from Services.appInfo.version (from Services.jsm).

When connected to Fenix/Firefox Preview, we currently get:

  • "Mozilla Nightly" for the brandFullName string
  • the gecko version (eg 68.0.a1) for Services.appInfo.version

For the browser name we can for now hardcode "Firefox Preview" / "Firefox Preview Beta" / "Firefox Preview Nightly", but it would be nice to have the brand name available via a localized string or any other API.

For the version, I don't think you would like to show the firefox version, but rather the application version? Maybe for now we can get it from ADB when we connect to the browser? But similarly it would be nice to have it available via an API.

Current bugzilla bug to improve Fenix/Firefox Preview support in remote debugging is https://bugzilla.mozilla.org/show_bug.cgi?id=1542286 for reference.

Thanks!

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added the needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org label Apr 30, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Apr 30, 2019

@cpeterso is there a GV bug for this?

@vesta0 vesta0 added needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org and removed needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org labels Apr 30, 2019
@vesta0 vesta0 added this to the Bugs milestone Apr 30, 2019
@vesta0 vesta0 added P2 Upcoming release 🐞 bug Crashes, Something isn't working, .. labels Apr 30, 2019
@cpeterso
Copy link

@snorp - What do you think we should do here? Is Gecko handling the remote debugging protocol itself or does GV or the app mediate the remote connections?

IIUC, GV doesn't know the name or version of the app embedding GV, but we could probably sniff the app's metadata at run-time to return meaningful messages in the remote debugging protocol.

@bifleming bifleming added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jun 26, 2019
@vesta0 vesta0 added this to Unnassigned to Release in Fenix: A-S Bugs Jul 8, 2019
@boek boek removed this from the Bugs and Polish milestone Jul 17, 2019
@vesta0 vesta0 removed this from the Bugs and Polish milestone Jul 24, 2019
@cpeterso
Copy link

GV bug 1542286 (to show the proper runtime name and app icon for Fenix in about:debugging) was fixed in GV 68. Does this Fenix issue require more GV work?

@juliandescottes
Copy link
Author

Any update here, it seems the code we initially used in remote debugging is starting to break cf https://bugzilla.mozilla.org/show_bug.cgi?id=1589087

@juliandescottes
Copy link
Author

GV bug 1542286 (to show the proper runtime name and app icon for Fenix in about:debugging) was fixed in GV 68. Does this Fenix issue require more GV work?

@cpeterso Sorry missed your message! Nothing was fixed in GV in this bug, we simply used hardcoded strings and workarounds in order to have something ready for the release for Firefox Preview. We would still need a reliable API to get the runtime name and version

@cpeterso
Copy link

We would still need a reliable API to get the runtime name and version

I see. I filed a new GV bug requesting this new API: https://bugzilla.mozilla.org/show_bug.cgi?id=1589805

@boek boek added this to Backlog in Fenix: GeckoView Oct 21, 2019
@data-sync-user data-sync-user changed the title Retrieve branding name and version from chrome priv JS (remote debugging) FNX3-15990 ⁃ Retrieve branding name and version from chrome priv JS (remote debugging) Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15990 ⁃ Retrieve branding name and version from chrome priv JS (remote debugging) FNX-489 ⁃ Retrieve branding name and version from chrome priv JS (remote debugging) Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX-489 ⁃ Retrieve branding name and version from chrome priv JS (remote debugging) Retrieve branding name and version from chrome priv JS (remote debugging) Aug 25, 2020
@stale
Copy link

stale bot commented Feb 21, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 21, 2021
@stale stale bot closed this as completed Feb 28, 2021
Fenix: GeckoView automation moved this from Backlog to Done Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org P2 Upcoming release 🙅 waiting Issues that are blocked or has dependencies that are not ready wontfix
Projects
No open projects
Development

No branches or pull requests

6 participants