Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Blocking autoplay video (or just muting sound) is not working on Reddit AMP pages #20233

Closed
jant90 opened this issue Jul 2, 2021 · 12 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Media needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org qa-triaged Issues triaged by qa 🙅 waiting Issues that are blocked or has dependencies that are not ready

Comments

@jant90
Copy link

jant90 commented Jul 2, 2021

When visiting a Reddit AMP page videos on there will autoplay with sound, even when autoplay is blocked (also, just blocking sound doesn't work either). I'm not familiar with other sites using AMP that use video so I couldn't test, but it's possible this happens on other (AMP) sites as well. When opening the tab overview I'm able to pause the video, so Firefox is aware of the video playing.

In my case these videos are outside the viewport so pausing is not easily possible without scrolling and searching the video first which makes this behavior all the more frustrating.

As far as I can tell this happens both Google (google.com/amp) and Reddit (amp.reddit.com) AMP pages when following them from the Google search results. When manually opening an AMP page (e.g. by pasting an url in the address bar) videos won't autoplay.

This issue has been going on for a long time, e.g. I found this 2 year old post on Reddit describing this very issue.

Short video showing this issue (be sure to enable sound):

Screen_Recording_20210702-171824_Firefox.mp4

Steps to reproduce

  1. Search Google for a Reddit post, e.g. "Xbox One Tech Support Reddit" (gaming subreddits often have videos).
  2. Follow the link to a Reddit AMP page.
  3. Wait a few seconds until a video starts autoplaying.
    Note: videos don't always play automatically but when scrolling past it autoplay seems to trigger consistently.

Expected behavior

Videos won't autoplay (or are muted) when autoplay video (or audio) is turned off in settings.

Actual behavior

Videos play with sound.

Device information

  • Samsung Galaxy S10e
  • Android 11
  • Firefox 89.1.1 with Google Search Fixer add-on (might change AMP results?)

P.S. I HATE AMP and I wish it would die.

┆Issue is synchronized with this Jira Task

@jant90 jant90 added the 🐞 bug Crashes, Something isn't working, .. label Jul 2, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 2, 2021
@Nickoriginal
Copy link

Nickoriginal commented Jul 2, 2021

https://amp.reddit.com/r/xboxone/comments/88jbo6/thanks_to_the_guy_who_recommended_buying/
Reproducible in Firefox 89.1.1 on Samsung Galaxy A20s, Android 10 when manually opening an AMP page. Video plays with sound when it shouln't with Autoplay -> Block audio and video enabled.

@jant90
Copy link
Author

jant90 commented Jul 2, 2021

Thanks for confirming. I wasn't sure whether I should include urls because when opening them directly I can't reproduce the issue (as I mentioned in the OP).

@LaurentiuApahideanSV
Copy link

@jant90 What option did you use to turn of autoplay?

@jant90
Copy link
Author

jant90 commented Jul 5, 2021

The only native option in Firefox, in settings go to Site permissions > Autoplay and choose option "Block audio and video".

@Nickoriginal
Copy link

The only native option in Firefox, in settings go to Site permissions > Autoplay and choose option "Block audio and video".

@LaurentiuApahideanSV LaurentiuApahideanSV added the qa-triaged Issues triaged by qa label Jul 5, 2021
@LaurentiuApahideanSV
Copy link

I can confirm the issue is reproducible on Firefox RC 89.1.1 and Nightly 2021-07-05.

Devices used:

  • OnePlus 6T (Android 9)
  • Samsung Galaxy S8 (Android 8.0.0)

@amedyne amedyne removed the needs:triage Issue needs triage label Jul 13, 2021
@amedyne amedyne added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jul 13, 2021
@mcarare
Copy link
Contributor

mcarare commented Jul 13, 2021

cc @Amejia481 because you might have more insight on this. To me, it seems like a problem in GV, not something we can handle in Fenix.

@Amejia481
Copy link
Contributor

Sure, I will take a look and report back 👍🏽 .

@Amejia481
Copy link
Contributor

Amejia481 commented Jul 13, 2021

It looks like this is a platform issue, I'm able to reproduce the same problem using the mobile view on Firefox desktop
I just have to navigate to https://amp.reddit.com/r/xboxone/comments/88jbo6/thanks_to_the_guy_who_recommended_buying/ and scroll to the videos section, just waiting for a few second for the videos to load. I will open a bugzilla bug for it.

image

image

The issue is not reproducible in normal mode.

@Amejia481
Copy link
Contributor

This is the bug https://bugzilla.mozilla.org/show_bug.cgi?id=1720337

@Amejia481 Amejia481 added needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Jul 13, 2021
@mcarare mcarare moved this from Ready for Engineering (min-5 ; max-22) to With Dependencies in Android Engineering Team Kanban board Jul 13, 2021
@plwt
Copy link

plwt commented Jul 30, 2021

User feedback with further example: https://support.mozilla.org/en-US/questions/1345456#answer-1431490

@amedyne
Copy link
Contributor

amedyne commented Aug 9, 2021

Closing this one to track platform issue in bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1720337

@amedyne amedyne closed this as completed Aug 9, 2021
Android Engineering Team Kanban board automation moved this from With Dependencies to Done Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Media needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org qa-triaged Issues triaged by qa 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
No open projects
Development

No branches or pull requests

7 participants