Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Sync automatically after a short while #2164

Closed
sv-ohorvath opened this issue Apr 30, 2019 · 8 comments
Closed

[Bug] Sync automatically after a short while #2164

sv-ohorvath opened this issue Apr 30, 2019 · 8 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Bookmarks Feature:Sync needs:ac Needs Android Component Work P1 Current sprint

Comments

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Apr 30, 2019

Steps to reproduce

  1. Sign in on 2 devices.
  2. Add a few bookmarks on one of them.
  3. Wait to sync automatically.
    1. Expected behavior
      AFAIK on Fennec, the new bookmarks are synced automatically.
    2. Actual behavior
      No automatic sync after 1 hour or more since new bookmarks were added.
    3. Device information
  • Android devices: Pixel, Mi 4i (Android 5.0.2)
  • Fenix version: 4/29

┆Issue is synchronized with this Jira Task

@sv-ohorvath sv-ohorvath added the 🐞 bug Crashes, Something isn't working, .. label Apr 30, 2019
@grigoryk grigoryk added Feature:Sync needs:ac Needs Android Component Work labels Apr 30, 2019
@grigoryk
Copy link
Contributor

This is part of the a-c sync manager, aka "heuristic syncing". I'll look for a relevant issue.

@vesta0
Copy link
Collaborator

vesta0 commented May 10, 2019

@grigoryk did you find a relevant issue? Do we want to increase the sync frequency?

@vesta0 vesta0 added this to the Bugs milestone May 10, 2019
@vesta0 vesta0 added the P1 Current sprint label May 10, 2019
@vesta0 vesta0 added this to High priority backlog (not in the current sprint) in Fenix Sprint Kanban May 24, 2019
@sv-ohorvath
Copy link
Contributor Author

This has an impact on Sending tabs, which you expect to happen almost instantly.

@sv-ohorvath sv-ohorvath changed the title [Bug] Sync automatically after adding bookmarks/a while [Bug] Sync automatically after a short while May 27, 2019
@vesta0
Copy link
Collaborator

vesta0 commented May 28, 2019

@sarentz will open a new bug for a workaround to this issue.

@bifleming bifleming added this to 🐉 Fenix Backlog in A-C: Android Components Sprint Planning May 28, 2019
@bifleming bifleming moved this from High priority backlog (not in the current sprint) to Ready for Dev in Fenix Sprint Kanban May 28, 2019
@bifleming bifleming added Release Blocker Blocks a Release and removed P1 Current sprint labels May 30, 2019
@grigoryk
Copy link
Contributor

@sv-ohorvath sending/receiving tabs is no longer technically part of Sync like it was in Fennec, so this doesn't have impact on tabs. We have a separate mechanism to receive tabs; currently we poll for new tabs every 15 minutes, and soon we'll be landing push support which should make receiving tabs nearly-instant.

Also, we already sync on a schedule, every four hours. And now that #2955 landed, we'll sync on app coming into foreground. So I'd say we should be in an OK place with regards to "data liveliness".

Given all of the above, I don't think this should be an MVP blocker.

@grigoryk grigoryk removed the Release Blocker Blocks a Release label May 30, 2019
@vesta0 vesta0 added the P1 Current sprint label May 30, 2019
@vesta0 vesta0 removed this from Ready for Dev in Fenix Sprint Kanban May 30, 2019
@bifleming bifleming moved this from 🐉 Fenix Backlog to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Jun 24, 2019
@ekager
Copy link
Contributor

ekager commented Jul 12, 2019

Sounds like we can close this issue?

@pocmo pocmo removed this from ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Jul 15, 2019
@pocmo
Copy link
Contributor

pocmo commented Jul 15, 2019

AC issue: mozilla-mobile/android-components#2727

@boek boek removed this from the Bugs and Polish milestone Jul 17, 2019
@sblatz sblatz added this to Prioritized Bug Backlog in Fenix Sprint Kanban Jul 20, 2019
@vesta0 vesta0 removed this from the Bugs and Polish milestone Jul 24, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Aug 8, 2019

Closing this issue since this no longer impacts Send Tab + we will be implementing Sync Manager soon.

@vesta0 vesta0 closed this as completed Aug 8, 2019
Fenix Sprint Kanban automation moved this from Prioritized Bug Backlog to Done Aug 8, 2019
@data-sync-user data-sync-user changed the title [Bug] Sync automatically after a short while FNX2-17722 ⁃ [Bug] Sync automatically after a short while Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-17722 ⁃ [Bug] Sync automatically after a short while FNX3-16110 ⁃ [Bug] Sync automatically after a short while Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16110 ⁃ [Bug] Sync automatically after a short while FNX-5492 ⁃ [Bug] Sync automatically after a short while Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5492 ⁃ [Bug] Sync automatically after a short while [Bug] Sync automatically after a short while May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Bookmarks Feature:Sync needs:ac Needs Android Component Work P1 Current sprint
Projects
None yet
Development

No branches or pull requests

9 participants