History UI deletion of items is very buggy

[grigoryk]

Hard to describe specific problems, but it appears to barely work for search groups (multiple deletion steps are required, e.g. delete a group, close the ui, open the ui, delete what's still remaining of the group, etc), and possibly for visits matching items in the groups.

STRs is to have a bunch of history, a few search groups, then try deleting items, closing the history UI, reopening it, and observing items re-appear.

┆Issue is synchronized with this Jira Task

[mariansima]

Alternative steps to reproduce:

1. Create a search group
2. Close the tabs belonging to the group
3. Remove them from Recently closed tabs in History UI
4. Remove items from the group in History UI

Expected: The group items are removed from the group and history

Actual: The history items show up again without the search group

Verified on Samsung Galaxy A8 (Android 0) with Firefox Nightly 96.0a1 2021-11-25 and 95.0.0-beta.6 2021-11-25

[delia-pop]

Reproducible on Beta 100.0.0-beta.4 with Google Pixel 6 (Android 12).

[stale]

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mavduevskiy]

@delia-pop
Could you please verify if the issue was fixed?
I was doing some work on history in March, and the usecase that @mariansima has described was working as intended.

[delia-pop]

Tested with the latest Fenix versions (Nightly 111.0a1 from 01/17, Beta 109.0b6 and RC 109.1.1 with Xiaomi 12 Pro (Android 13). I can no longer reproduce the issues mentioned above.