[Bug]: Fullscreen YouTube video shows toolbar-sized gap

[emilio]

Steps to reproduce

1. Go to any YouTube video like https://m.youtube.com/watch?v=27OzhD4YFcQ

2. Click the fullscreen button.

Expected behaviour

The video takes the whole screen.

Actual behaviour

There is a gap. See screenshot:

Seems like a recent regression, doesn't reprobon release.

Device name

One plus pro 9

Android version

Android 11

Firefox release type

Firefox Nightly

Firefox version

97.0a1 (Build #2015856171), 0563bf3+ AC: 97.0.20220107193451, 379cb84d88 GV: 97.0a1-20220107155514 AS: 87.1.0

Device logs

No response

Additional information

No response

┆Issue is synchronized with this Jira Task

[SoftVision-LorandJanos]

Hi @emilio! Thanks for your report!
I couldn't reproduce the issue you described.
Tested in the latest Nightly (2022-01-10) and latest Release (96.1.1) using the following devices:

• Oppo Reno 6 (Android 11).
• Google Pixel 4 (Android 12).

Please check if you reproduce it with a clean build. Or check if you're using other apps or made some changes in settings that might cause this issue. Thank you!

[emilio]

@SoftVision-LorandJanos I can definitely repro on a clean build. Trying to bisect this.

[emilio]

Git bisect says: 5d8587e is the first bad commit. @MickeyMoz do you know how to tell which gecko and android-components changes does that include?

[Mugurell]

Might be because of mozilla-mobile/android-components#11375. Will look into it.

[emilio]

Yeah, thanks to @MickeyMoz who helped me to get the android-components commits (below for my own reference):

There are multiple options:

  *  If you have that build running somewhere, the about screen shows the A-C commit
  *  You can look at the POM file of a component of that version, e.g.L https://nightly.maven.mozilla.org/maven2/org/mozilla/components/browser-engine-gecko/97.0.20220106143323/browser-engine-gecko-97.0.20220106143323.pom
  *  You can look at treeherder and try to find the build/commit matching this timestamp :)

(The second option will list the commit: <tag>a24ab928db495a17281a0bab0d957b6399def131</tag>)

I came up with the range mozilla-mobile/android-components@796891a...a24ab92, which indeed points at your changes. Thanks for looking into it! Let me know if I can help with something :)

[sheikh-azharuddin]

I am getting a white bar in the bottom

[sheikh-azharuddin]

Any fix for this issue? The issue was introduced overnight but yet no fix after a Week! Although it's a nightly version but we users don't have any option..I am using nightly because of custom add on support..

[Mugurell]

Should be fixed in the next Nightly.

[SoftVision-LorandJanos]

I've managed to reproduce the issue on a Huawei P30 (Android11).
Tested with the Nightly build mentioned in the report (97.0a1 - 2022-01-07).

Verified as fixed on the latest Nightly 98.0a1 (2022-01-20).
Closing the ticket as fixed.

[fprietog]

IMHO this is a nasty bug because affects to a intensive used function; full screen video playing.

I don't understand why this bug, that was discovered during testing of version 97, is going to be solved in version 98 instead of 97. Now we have the bug in the stable version probably for a whole releasing cicle... I think it shuold be backported.

Thanks and best regards.

[gabrielluong]

This was fixed in mozilla-mobile/android-components#11527 for reference.

[rvandermeulen]

FYI, we expect to ship a 97.2.0 release later this week which will address this.

[LaurentiuApahideanSV]

I tested the issue on RC 97.2.0 and the issue no longer occurs. There is no gap when watching a youtube video in full screen mode.

Devices used:

• Google Pixel 6 (Android 12)
• Google Pixel 4 (Android 12)