Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Simpifly the parameters passed-in for DefaultTabsTrayController #26017

Closed
Tracked by #25722
MozillaNoah opened this issue Jul 13, 2022 · 3 comments
Closed
Tracked by #25722

Simpifly the parameters passed-in for DefaultTabsTrayController #26017

MozillaNoah opened this issue Jul 13, 2022 · 3 comments
Assignees
@MozillaNoah
Labels
eng:health Improve code health 🙅 waiting Issues that are blocked or has dependencies that are not ready

Comments

@MozillaNoah
Copy link
Contributor

MozillaNoah commented Jul 13, 2022 •
edited by data-sync-user
Loading

Per #25895 (comment), since an activity is now being passed into DefaultTabsTrayController, the large parameter list could be condensed by obtaining several of them directly from the activity reference.

┆Issue is synchronized with this Jira Task
@MozillaNoah MozillaNoah added the eng:health Improve code health label Jul 13, 2022
@MozillaNoah MozillaNoah mentioned this issue Jul 13, 2022
Closed
4 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 13, 2022
@MozillaNoah MozillaNoah added 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed needs:triage Issue needs triage labels Jul 13, 2022
@MozillaNoah
Copy link
Contributor Author

MozillaNoah commented Jul 13, 2022 •
edited
Loading

Requires #25722 to land first

@MozillaNoah MozillaNoah changed the title Simply the parameters passed-in for DefaultTabsTrayController Simpifly the parameters passed-in for DefaultTabsTrayController Jul 14, 2022
@MozillaNoah MozillaNoah mentioned this issue Dec 6, 2022
Closed
13 tasks
@stale
Copy link

stale bot commented Jan 13, 2023

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 13, 2023
@MozillaNoah MozillaNoah self-assigned this Jan 13, 2023
@gabrielluong
Copy link
Member

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1814206

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MozillaNoah MozillaNoah

Labels
eng:health Improve code health 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabrielluong @MozillaNoah