Control characters shouldn't be considered part of the URL when filling link from clipboard

[yedayak]

What is the user problem or growth opportunity you want to see solved?

When I have text in my clipboard that has a link followed by a control character - for example \u200E - Firefox offers to "fill link from clipboard" with the link. When you accept the offer the actual link that gets filled includes the control character, url encoded at the end.
Example: https://t.co/0qWwlrKXtm‎ Turns to https://t.co/0qWwlrKXtm%E2%80%8E. This behavior kind of makes sense when directly pasting the link directly, but I think the selection of links from text should be smart enough to not include those types of control characters when detecting links in text.

How do you know that this problem exists today? Why is this important?

I experience this issue when copying text in right to left languages (Hebrew) that include \u200E and \u200F, and selecting links from that text does not work without manually editing the url.

Who will benefit from it?

Anyone who uses the "fill link from clipboard" with text that has control characters, such as hebrew or arabic text.

The code that deals with this is here: https://github.com/mozilla-mobile/android-components/blob/9a56645ca01d7ee9bb40aa49c848cadce652b528/components/support/utils/src/main/java/mozilla/components/support/utils/WebURLFinder.kt#L78 and here:

fenix/app/src/main/java/org/mozilla/fenix/utils/ClipboardHandler.kt

Line 59 in 0127b39

fun extractURL(): String? {

┆Issue is synchronized with this Jira Task

[stale]

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[boek]

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1813804

Change performed by the Move to Bugzilla add-on.