Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Profiles with more than one first_run_date in the first session ping #27061

Closed
lucia-vargas-a opened this issue Sep 19, 2022 · 6 comments
Closed
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Telemetry

Comments

@lucia-vargas-a
Copy link

lucia-vargas-a commented Sep 19, 2022

Steps to reproduce

Querying the number of first_run_date per client_id in the first session ping returns more than one value.

WITH first_runs AS
(
  SELECT
    client_info.client_id, COUNT(1) AS dates
  FROM
    `moz-fx-data-shared-prod.org_mozilla_firefox_stable.first_session_v1`
  WHERE
  DATE(submission_timestamp) >= '2021-01-01'
  AND DATE(submission_timestamp) = SAFE.PARSE_DATE('%F', SUBSTR(client_info.first_run_date, 1, 10))
  AND ping_info.seq = 0
  GROUP BY 1
)
SELECT
  COUNT(client_id) clients,
  COUNT(IF(dates>1, client_id, NULL)) AS clients_with_many_first_run_date
FROM first_runs
WHERE dates>1

Expected behaviour

Each client_id has a single first_run_date in moz-fx-data-shared-prod.org_mozilla_firefox_stable.first_session_v1 and a unique seq.
The code will only send the ping if it hasn't been sent yet.

Actual behaviour

There are 226 profiles with more than one first_session date and same seq between 2021 and 2022. (see query above)

Device name

NA

Android version

NA

Firefox release type

Firefox

Firefox version

NA

Device logs

NA

Additional information

This is related to a Glean first session ping.

┆Issue is synchronized with this Jira Task

@lucia-vargas-a lucia-vargas-a added needs:triage Issue needs triage 🐞 bug Crashes, Something isn't working, .. labels Sep 19, 2022
@kbrosnan
Copy link
Contributor

I expect this is people that override our blocking of Android backup. This requires root.

@kbrosnan kbrosnan added Feature:Telemetry and removed needs:triage Issue needs triage labels Sep 19, 2022
@chutten
Copy link

chutten commented Sep 21, 2022

Seems plausible, as the proportions we're seeing aren't inconsistent with such a niche population. Is there a way we could confirm by detecting their override, @kbrosnan ?

@kbrosnan
Copy link
Contributor

We don't have data on if the user is rooted.

@chutten
Copy link

chutten commented Sep 22, 2022

Is it possible to instrument? I might dust off my Javalike language skills and implement such instrumentation if it'd give us confidence. But I don't know Android well enough to know if things like this will get us what we need.

@kbrosnan
Copy link
Contributor

Yes it is possible. Opened the above issue to look into collecting that data. It would be a few months before this hits release users.

@csadilek csadilek changed the title [Bug]: Profiles with more than one first_run_date in the first session ping Profiles with more than one first_run_date in the first session ping Jan 9, 2023
@csadilek
Copy link
Contributor

csadilek commented Jan 9, 2023

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1809326

Change performed by the Move to Bugzilla add-on.

@csadilek csadilek closed this as completed Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Telemetry
Projects
None yet
Development

No branches or pull requests

4 participants