Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove all use of now-removed Glean events API #28588

Closed
badboy opened this issue Jan 19, 2023 · 1 comment
Closed

Remove all use of now-removed Glean events API #28588

badboy opened this issue Jan 19, 2023 · 1 comment
Labels
needs:triage Issue needs triage

Comments

@badboy
Copy link
Member

badboy commented Jan 19, 2023

Ref #19967, #28587

This API is still references here: https://github.com/mozilla-mobile/fenix/blob/3e7d0bf8fbfbcb88eb447d63cf4b74beb14d88af/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt

Further down the EventWrapper is set to null unconditionally, and references in track.

That one is then used here:

metrics.track(Event.GrowthData.SetAsDefault)
metrics.track(Event.GrowthData.FirstWeekSeriesActivity)

and I think here: https://github.com/mozilla-mobile/fenix//blob/main/app/src/main/java/org/mozilla/fenix/components/metrics/MetricController.kt#L395

and I don't understand how that all still works together.
But I think this basically doesn't track any events anymore because of the event.wrapper = null mentioned above.

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 19, 2023
@cpeterso
Copy link

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1812943

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:triage Issue needs triage
Projects
None yet
Development

No branches or pull requests

2 participants