Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add bookmark through context menu #5016

Closed
2 tasks
vesta0 opened this issue Aug 29, 2019 · 12 comments
Closed
2 tasks

Add bookmark through context menu #5016

vesta0 opened this issue Aug 29, 2019 · 12 comments
Labels
E5 Estimation Point: about 5 days eng:ready Ready for engineering Feature:Bookmarks Feature:FennecTransition feature request 🌟 New functionality and improvements needs:ac Needs Android Component Work

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Aug 29, 2019

User Story

  • As a user, I want to be able to long press on a link on a website, and have the option to bookmark that link, so I can quickly bookmark a page and go back to it later without having to load the page

Requirements

  • Add "add a bookmark" to the link context menu (@jpfaller to provide exact strings)
  • Add a telemetry probe to measure taps on "add a bookmark" through the context menu

Acceptance Criteria

  • I can add a bookmark through the context menu.

Please use Fennec UI as reference:

1587772076

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added this to To be Triaged in Fenix Sprint Kanban via automation Sep 19, 2019
@vesta0 vesta0 moved this from To be Triaged to Prioritized UX Backlog in Fenix Sprint Kanban Sep 19, 2019
@vesta0 vesta0 added this to Q4 2019 in Fenix Feature Maturity Sep 19, 2019
@lime124 lime124 added the ux:xs label Sep 23, 2019
@boek boek added the E2 Estimation Point: easy, half a day to 2 days label Sep 23, 2019
@vesta0 vesta0 moved this from Prioritized UX Backlog to Prioritized Feature Backlog in Fenix Sprint Kanban Oct 1, 2019
@vesta0
Copy link
Collaborator Author

vesta0 commented Oct 1, 2019

@lime124 I propose that we skip UX for this issue and refer to the Fennec UI instead.

@vesta0 vesta0 added the needs:strings Needs strings label Oct 1, 2019
@vesta0
Copy link
Collaborator Author

vesta0 commented Oct 1, 2019

@liuche this needs to be re-sized as I added telemetry to the requirements.

@lime124
Copy link
Collaborator

lime124 commented Oct 2, 2019

@jpfaller can we reuse bookmark link from fennec for our context menu? thanks!

@vesta0 vesta0 added E5 Estimation Point: about 5 days and removed E2 Estimation Point: easy, half a day to 2 days labels Oct 2, 2019
@jpfaller
Copy link

jpfaller commented Oct 2, 2019

Yep, I think it can be re-used.

@lime124 lime124 added eng:ready Ready for engineering and removed needs:strings Needs strings labels Oct 2, 2019
@liuche
Copy link
Contributor

liuche commented Oct 3, 2019

adding triage label to re-size, and this now has additional telemetry requirements.

@vesta0
Copy link
Collaborator Author

vesta0 commented Oct 3, 2019

We resized this from E2 to E5 during backlog grooming today.

@jpfaller jpfaller removed their assignment Oct 3, 2019
@vesta0
Copy link
Collaborator Author

vesta0 commented Oct 9, 2019

@lime124 should we also add a "add to collection" option to this menu? I am thinking maybe that is in fact more useful/relevant. I am thinking the only reason a user would bookmark a link they haven't opened is to have the option to come back to it later without interrupting their browsing activity.

@vesta0 vesta0 removed this from Could in Fenix Q4 Feature Backlog Oct 28, 2019
@vesta0 vesta0 moved this from Q4 2019 to Q1 2020 in Fenix Feature Maturity Oct 28, 2019
@lime124
Copy link
Collaborator

lime124 commented Oct 28, 2019

Adding group triage - does this have any dependencies? can a contributor pick it up?

@vesta0 Can we open that in a separate issue? I'd like to keep the scope on this one small/contained since it's ready for eng - there may be some additional design decisions on the flow that need to be made.

@vesta0 vesta0 added the needs:ac Needs Android Component Work label Oct 29, 2019
@sblatz
Copy link
Contributor

sblatz commented Oct 29, 2019

This is AC work we can do as Fenix engineers if we'd like.

Let's modify the ContextMenuCandidate.kt file

@lime124. @vesta0 said she'd open a separate ticket for the other request :)

@vesta0
Copy link
Collaborator Author

vesta0 commented Oct 29, 2019

@lime124 sure I can create a separate issue for "add to a collection". That aside, do you think "add bookmark" is a useful feature on its own? I just want to make sure that we look at all the context menu options holistically before adding new things.

@vesta0 vesta0 removed this from Prioritized Feature Backlog in Fenix Sprint Kanban Nov 4, 2019
@vesta0 vesta0 moved this from Q1 2020 to Won't do in Fenix Feature Maturity Feb 5, 2020
@vesta0 vesta0 removed this from Could in Fenix Q1 Feature Backlog Feb 5, 2020
@vesta0 vesta0 removed the could label Mar 29, 2020
@vesta0 vesta0 removed this from Q2 2020 in Fenix Feature Maturity Mar 29, 2020
@vesta0 vesta0 removed this from Could in Fenix Q2 Feature Backlog Mar 29, 2020
@vesta0 vesta0 added the feature request 🌟 New functionality and improvements label Mar 29, 2020
@jackyzy823
Copy link

The android part is not so hard to complete , see https://github.com/jackyzy823/android-components/tree/copy-link-text and
https://github.com/jackyzy823/fenix/tree/context-menu-bookmark

The question is same as #16582 (comment)

You can not get bookmark's link text (aka title) from geckoview

Ref: fennec's implment:
https://hg.mozilla.org/releases/mozilla-esr68/file/tip/mobile/android/chrome/content/browser.js#l1165

@boek
Copy link
Contributor

boek commented Jan 26, 2023

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1812724

Change performed by the Move to Bugzilla add-on.

@boek boek closed this as completed Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:ready Ready for engineering Feature:Bookmarks Feature:FennecTransition feature request 🌟 New functionality and improvements needs:ac Needs Android Component Work
Projects
None yet
Development

No branches or pull requests

8 participants