Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Starting a Custom Tab from cold-boot starts the world #5045

Closed
jonalmeida opened this issue Aug 30, 2019 · 3 comments
Closed

Starting a Custom Tab from cold-boot starts the world #5045

jonalmeida opened this issue Aug 30, 2019 · 3 comments
Labels
needs:investigation P3 Some future sprint performance Possible performance wins wontfix

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Aug 30, 2019

When you start a custom tab[1], this also invokes your FxA account/sync, etc. which doesn't really need to be started since we just want to load the browser engine and auto-fill support (at most).

We should consider how to lazy/not load the rust components when in a Custom Tab.

This might mean making rust component services aware of the sessionId so that we can differ the loading to later.

[1]: While I refer to custom tabs, this affects TWAs and PWAs as well.

┆Issue is synchronized with this Jira Task

@jonalmeida jonalmeida added needs:investigation performance Possible performance wins labels Aug 30, 2019
@jonalmeida
Copy link
Contributor Author

Documenting some offline conversations with @colintheshots and @grigoryk :

  • Lazy loading is something we should try to do more often in general, although this can be harder as code is intertwined.
    • "We may get away with not initializing some native objects (e.g. FirefoxAccount rust one), but we're still loading the so files".
  • Having the megazord complicates what gets accessed.
  • Maybe anything that accesses a native object should be wrapped in a lazy initializer?
  • Today in Custom Tabs/TWAs/PWAs, we don't need to do any of this since we don't want those features. Tomorrow we might, so we could potentially differ the bigger problem to later and figure out the easy version: don't load native code in a CT/TWA/PWA.

@hawkinsw
Copy link
Contributor

@jonalmeida Talk to me about this tomorrow? I'd love to hear more and see if there is something that I can do to help.

@mcomella mcomella added this to Needs triage in Performance, front-end roadmap Oct 7, 2019
@mcomella mcomella moved this from Needs prioritization to Low impact (unprioritized) in Performance, front-end roadmap Nov 11, 2019
@boek boek added the P3 Some future sprint label Dec 28, 2019
@sraturi sraturi assigned sraturi and unassigned sraturi Aug 8, 2020
@stale
Copy link

stale bot commented Feb 4, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 4, 2021
@stale stale bot closed this as completed Feb 11, 2021
Performance, front-end roadmap automation moved this from Low impact (unprioritized) to Done Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:investigation P3 Some future sprint performance Possible performance wins wontfix
Projects
None yet
Development

No branches or pull requests

4 participants