Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Saved images are not properly names (can't open from in app notif, no name in notif) #6519

Closed
AndiAJ opened this issue Nov 8, 2019 · 8 comments
Closed

[Bug]Saved images are not properly names (can't open from in app notif, no name in notif) #6519

AndiAJ opened this issue Nov 8, 2019 · 8 comments
Assignees
@BranescuMihai @sblatz
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Nov 8, 2019 •
edited by data-sync-user

Steps to reproduce

  1. Navigate to theverge.com
  2. Long tap on one of the featured articles or images
  3. Select "Save image" from the context menu
  4. From the Android taskbar tap on the download confirmation to open the downloaded image

Expected behavior

The image should be opened after tapping the notification

Actual behavior

The downloaded image isn't opened after tapping the notification

Device information

  • Android device:
    • Google Pixel 3a XL (Android 10)
    • Google Pixel 3a XL (Android 9)
    • Huawei Mate 20 Lite (Android 8.1.0)

  • Fenix version:
    • Beta 3.0.0-beta.1 Build #13112229 from 7/11
    • Nightly Build #13120608 from 8/11

Notes

► Video
20191108_124622

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added the 🐞 bug Crashes, Something isn't working, .. label Nov 8, 2019
@AndiAJ AndiAJ changed the title [Bug]Saved images can't be opened [Bug]Saved images can't be opened from the Android taskbar confirmation Nov 8, 2019
@AndiAJ AndiAJ added Feature:Download S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Nov 8, 2019
@BranescuMihai BranescuMihai self-assigned this Nov 8, 2019
@BranescuMihai BranescuMihai mentioned this issue Nov 12, 2019
Closed
@sv-ohorvath sv-ohorvath added S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill and removed S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Nov 19, 2019
Closed
@BranescuMihai BranescuMihai mentioned this issue Nov 20, 2019
Closed
@sblatz sblatz changed the title [Bug]Saved images can't be opened from the Android taskbar confirmation [Bug]Saved images are not properly downloaded (can't open, no name) Nov 25, 2019
@sblatz
Copy link
Contributor

sblatz commented Nov 25, 2019 •
edited

This is effectively the same issue as #6576. Something is going wrong when downloading with "save image" that is causing both of these symptoms.

20191125_115945

@sblatz sblatz mentioned this issue Nov 25, 2019
Closed
@sblatz
Copy link
Contributor

sblatz commented Nov 25, 2019

So two things I've discovered:

  1. The "open" fails because it's not pointing to the correct file name.
  2. The download notification will open the image when tapped, so it is properly downloading, it's just not getting its file name properly set.

@sblatz sblatz changed the title [Bug]Saved images are not properly downloaded (can't open, no name) [Bug]Saved images are not properly names (can't open from in app notif, no name in notif) Nov 25, 2019
@sblatz sblatz mentioned this issue Nov 25, 2019
Closed
@sblatz
Copy link
Contributor

sblatz commented Nov 25, 2019

Will be fixed by mozilla-mobile/android-components#5151

@sblatz sblatz added the eng:qa:needed QA Needed label Nov 26, 2019
@sblatz sblatz self-assigned this Nov 26, 2019
@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Nov 27, 2019
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Nov 27, 2019

So two things I've discovered:

  1. The "open" fails because it's not pointing to the correct file name.
  2. The download notification will open the image when tapped, so it is properly downloading, it's just not getting its file name properly set.

@sblatz - You are right! ☺️

I've re-checked this matter and it is still reproducible on the latest Nightly Build #13310607 from 11/27 using the following devices:
• Google Pixel 3a XL (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)

► Video from Samsung S7 using Fenix
20191127_122500

► Video from Samsung S7 using Fennec
20191127_122704

@sblatz
Copy link
Contributor

sblatz commented Nov 27, 2019

Hi sorry about that, the AC version hadn’t been updated yet. It should be good to test in the next nightly!

@sblatz sblatz added the eng:qa:needed QA Needed label Nov 27, 2019
@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Nov 29, 2019 •
edited

@sblatz See #6615 (comment)
Tap Open on a saved image notification from wikipedia (no filename displayed), it will result in a can't load/open the file error.
Tap Open on the unsplash.com download (has filename displayed), it will open the file correctly.

@sv-ohorvath sv-ohorvath removed the eng:qa:needed QA Needed label Nov 29, 2019
@vesta0 vesta0 mentioned this issue Dec 5, 2019
Closed
7 tasks
@sblatz
Copy link
Contributor

sblatz commented Dec 10, 2019

Looks to be fixed 🎉

Untitled 2019-12-10 08_55_14

QA it should be in nightly tomorrow or working on master :)

@sblatz sblatz added the eng:qa:needed QA Needed label Dec 10, 2019
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Dec 11, 2019

Hi, verified as fixed on the latest Nightly Build #13450608 from 12/11 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• Motorola G4 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Video
20191212_124950

@AndiAJ AndiAJ closed this as completed Dec 11, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BranescuMihai BranescuMihai

@sblatz sblatz

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BranescuMihai @sv-ohorvath @sblatz @AndiAJ