Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Dark theme could have dark loading screen #7256

Closed
aha999 opened this issue Dec 17, 2019 · 5 comments
Closed

Dark theme could have dark loading screen #7256

aha999 opened this issue Dec 17, 2019 · 5 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Themes Dark mode, light mode, private browsing mode needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org P3 Some future sprint

Comments

@aha999
Copy link

aha999 commented Dec 17, 2019 •
edited by data-sync-user
Loading

When the dark theme is applied, the loading screen could be dark as well, instead of flashing white, when users press a search button.

┆Issue is synchronized with this Jira Task
@boek boek added Feature:Themes Dark mode, light mode, private browsing mode P2 Upcoming release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist 🐞 bug Crashes, Something isn't working, .. needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org labels Dec 18, 2019
@boek boek added this to Backlog in Fenix: GeckoView via automation Dec 18, 2019
@boek boek moved this from Backlog to Triage in Fenix: GeckoView Dec 18, 2019
@boek boek moved this from Triage to Backlog in Fenix: GeckoView Jan 7, 2020
@boek boek added P3 Some future sprint and removed P2 Upcoming release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Jan 7, 2020
@boek boek moved this from Backlog to Needs GV bug in Fenix: GeckoView Jan 7, 2020
@boek
Copy link
Contributor

boek commented Jan 22, 2020

https://bugzilla.mozilla.org/show_bug.cgi?id=1610968

@boek boek moved this from Needs GV bug to Backlog in Fenix: GeckoView Jan 22, 2020
@nt1m
Copy link

nt1m commented Mar 22, 2020

I think https://bugzilla.mozilla.org/show_bug.cgi?id=1408122 might already have fixed this on the GeckoView side. It landed in Firefox 75.

@ekager
Copy link
Contributor

ekager commented Mar 23, 2020

Can reproduce on Nightly with GV76
STR:

  1. Be in dark mode
  2. Launch search screen, select DDG as search engine, and search something

@robsmith11
Copy link

robsmith11 commented Apr 30, 2020 •
edited
Loading

According to the Gecko bug, a function to solve this is already exposed. Has anyone tried it on the Fenix side?

@ekager
Copy link
Contributor

ekager commented Apr 30, 2020

Yeah see #6313
Closing this for that ticket now

@ekager ekager closed this as completed Apr 30, 2020
@vesta0 vesta0 removed this from Backlog in Fenix: GeckoView Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Themes Dark mode, light mode, private browsing mode needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org P3 Some future sprint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@boek @nt1m @robsmith11 @ekager @aha999