Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Empty collection can be created #8726

Closed
Diana-Rus opened this issue Feb 25, 2020 · 1 comment
Closed

[Bug] Empty collection can be created #8726

Diana-Rus opened this issue Feb 25, 2020 · 1 comment
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Collections S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@Diana-Rus
Copy link

Diana-Rus commented Feb 25, 2020

Steps to reproduce

  1. Open app.
  2. Have at least 2 open tabs.
  3. Long tab on one open tab.
  4. Tap on the "Save" button, with the checked tab.
  5. Tap on the "Add new collection" button from bottom of the screen.
  6. From the "Name Collection" screen long tap on the present tab.
  7. Save collection.

Expected behavior

The user shouldn't be able to create empty Collection.

Actual behavior

Empty collection can be created.

Device information

  • Android device: OnePlus 6T (Android 9), Samsung Galaxy S9 (Android 8.0.0) and Sony Xperia Z5 (Android 7.0.0)
  • Fenix version: Firefox Preview Nightly 200225 (Build #20560606) GV: 75.0a1-20200223093951

Note:

  • Check gif:
    20200225-144840
  • No crash encountered after creating collection.
  • No problems when doing any of the following actions: sharing, open tabs, rename collection, add tab, delete collection.
  • The issue can be reproduced when there are multiple tabs added in the "Name Collection" screen

┆Issue is synchronized with this Jira Task

@Diana-Rus Diana-Rus added 🐞 bug Crashes, Something isn't working, .. Feature:Collections S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Feb 25, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 25, 2020
@Diana-Rus Diana-Rus changed the title [Bug]Collections-Empty collection can be created [Bug] Collections-Empty collection can be created Apr 3, 2020
@Diana-Rus Diana-Rus removed the needs:triage Issue needs triage label Apr 23, 2020
@eliserichards eliserichards added this to Inbox in Engineering triage via automation May 6, 2020
@eliserichards eliserichards moved this from Inbox to Collections in Engineering triage May 6, 2020
@eliserichards eliserichards changed the title [Bug] Collections-Empty collection can be created [Bug] Empty collection can be created May 6, 2020
@Diana-Rus
Copy link
Author

Hi, i'm going to close this as now there are other implementations(methods through which tabs can be added to a collection)

This issue does not occur in the "Rename collection" section - from previous implementation
This issue does not occur in the "Select tabs" section - from previous implementation

@liuche liuche removed this from Collections in Engineering triage Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Collections S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Development

No branches or pull requests

1 participant