-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Share] Share sheet implemented not according to spec #9332
Comments
Clarification question for @AmyYLee and @topotropic: does the “Share a link” section have a certain ordering of items? For example, “Copy link” seems to be the first item. Is it always the first item in all situations? The app icons that come after “Copy link”, do they get sorted by recently used, alphabetical, etc.? |
https://mozilla.invisionapp.com/share/PSQFWZ1Y4W8#/screens/346059768 is an outdated spec, no? It still shows the "sessions" concept which no longer exists in Fenix, so it's a very old mockup. And this mockup does not have a section for "recently used" at all. This feature was added in #4231 and there is a much newer mockup: https://app.abstract.com/share/e1a39a6b-2c3e-4fc4-b46c-0c78ec491112?mode=design&sha=f3bcad9f449216555fbf5cc31c3b9933b6538a96 |
@topotropic - Can you provide feedback/guidance? It looks like this was a temporary fix. |
@topotropic I think we should also consider having the option to remove apps from recent list. |
Yeah, the "recently used apps" section was added very recently in #4231 but maybe was based on an older spec? I'm not sure Could UX please chime in here with the "truth" of what the share sheet should look like today before we jump into fixing bugs with different mocks for each 😅 |
@topotropic Can you assist with this? |
@topotropic For follow-up |
@topotropic - Does this need further ux-investigation? |
Amy's suggestions sounds good to me:
@mcarare can you open a github issue to track your request? Thanks! |
See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi,
The share sheet has has horizontal scroll instead of a vertical scroll layout. Please reference original spec for guidance (@topotropic):
https://mozilla.invisionapp.com/share/PSQFWZ1Y4W8#/screens/346059768
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: