Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Share] Share sheet implemented not according to spec #9332

Closed
AmyYLee opened this issue Mar 23, 2020 · 10 comments
Closed

[Share] Share sheet implemented not according to spec #9332

AmyYLee opened this issue Mar 23, 2020 · 10 comments

Comments

@AmyYLee
Copy link
Collaborator

AmyYLee commented Mar 23, 2020

Hi,

The share sheet has has horizontal scroll instead of a vertical scroll layout. Please reference original spec for guidance (@topotropic):

https://mozilla.invisionapp.com/share/PSQFWZ1Y4W8#/screens/346059768

  1. "Recently Used" should be it's own row with no grey background
  2. "All Actions" should be the next row under it separated by a hairline above with vertical scroll (like native android share sheet).

Screen Shot 2020-03-23 at 16 52 12

┆Issue is synchronized with this Jira Task

@AmyYLee AmyYLee added 🐞 bug Crashes, Something isn't working, .. implementation review needs:triage Issue needs triage eng:ready Ready for engineering and removed 🐞 bug Crashes, Something isn't working, .. labels Mar 23, 2020
@brampitoyo
Copy link

Clarification question for @AmyYLee and @topotropic: does the “Share a link” section have a certain ordering of items?

For example, “Copy link” seems to be the first item. Is it always the first item in all situations?

The app icons that come after “Copy link”, do they get sorted by recently used, alphabetical, etc.?

@cadeyrn
Copy link
Contributor

cadeyrn commented Mar 23, 2020

https://mozilla.invisionapp.com/share/PSQFWZ1Y4W8#/screens/346059768 is an outdated spec, no? It still shows the "sessions" concept which no longer exists in Fenix, so it's a very old mockup. And this mockup does not have a section for "recently used" at all. This feature was added in #4231 and there is a much newer mockup: https://app.abstract.com/share/e1a39a6b-2c3e-4fc4-b46c-0c78ec491112?mode=design&sha=f3bcad9f449216555fbf5cc31c3b9933b6538a96

@AmyYLee
Copy link
Collaborator Author

AmyYLee commented Mar 23, 2020

https://mozilla.invisionapp.com/share/PSQFWZ1Y4W8#/screens/346059768 is an outdated spec, no? It still shows the "sessions" concept which no longer exists in Fenix, so it's a very old mockup. And this mockup does not have a section for "recently used" at all. This feature was added in #4231 and there is a much newer mockup: https://app.abstract.com/share/e1a39a6b-2c3e-4fc4-b46c-0c78ec491112?mode=design&sha=f3bcad9f449216555fbf5cc31c3b9933b6538a96

@topotropic - Can you provide feedback/guidance? It looks like this was a temporary fix.

@brampitoyo brampitoyo added needs:UX-feedback Needs UX Feedback and removed eng:ready Ready for engineering labels Mar 24, 2020
@mcarare
Copy link
Contributor

mcarare commented Mar 24, 2020

@topotropic I think we should also consider having the option to remove apps from recent list.

@ekager
Copy link
Contributor

ekager commented Mar 27, 2020

Yeah, the "recently used apps" section was added very recently in #4231 but maybe was based on an older spec? I'm not sure

Could UX please chime in here with the "truth" of what the share sheet should look like today before we jump into fixing bugs with different mocks for each 😅

@AmyYLee
Copy link
Collaborator Author

AmyYLee commented Apr 14, 2020

Yeah, the "recently used apps" section was added very recently in #4231 but maybe was based on an older spec? I'm not sure

Could UX please chime in here with the "truth" of what the share sheet should look like today before we jump into fixing bugs with different mocks for each 😅

@topotropic Can you assist with this?

@ekager ekager removed the needs:triage Issue needs triage label May 12, 2020
@AmyYLee
Copy link
Collaborator Author

AmyYLee commented Jun 3, 2020

@topotropic For follow-up

@AmyYLee
Copy link
Collaborator Author

AmyYLee commented Jul 10, 2020

@topotropic - Does this need further ux-investigation?

@topotropic
Copy link

Amy's suggestions sounds good to me:

  • "Recently Used" should be it's own row with no grey background
  • "All Actions" should be the next row under it separated by a hairline above with vertical scroll (like native android share sheet).

@mcarare can you open a github issue to track your request? Thanks!

@topotropic topotropic removed the needs:UX-feedback Needs UX Feedback label Jul 15, 2020
@topotropic topotropic removed their assignment Jul 15, 2020
@topotropic topotropic added the eng:ready Ready for engineering label Jul 15, 2020
@stale
Copy link

stale bot commented Feb 4, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 4, 2021
@stale stale bot closed this as completed Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants