Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Back and Forward buttons not updated in custom tabs #9463

Closed
sflorean opened this issue Mar 27, 2020 · 7 comments
Closed

[Bug]Back and Forward buttons not updated in custom tabs #9463

sflorean opened this issue Mar 27, 2020 · 7 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:CustomTabs Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. needs:ac Needs Android Component Work S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist wontfix

Comments

@sflorean
Copy link
Contributor

sflorean commented Mar 27, 2020

Steps to reproduce

  1. Set Nightly as the default browser.
  2. Go to Gmail and open a page.
  3. Open different links from the previous page.
  4. Tap the 3 dot menu.

Expected behavior

Back and Forward buttons are updated depending on what action we made.

Actual behavior

The buttons are not updated.

Device information

  • Android device: Samsung Galaxy Note 10 (Android 10).
  • Fenix version: Nightly 3/27, 4.2.0-beta.3.
  • Only when step 3 is performed through a highlighted word: Pixel 3 XL (Android 9), Pixel 2 (Android 9).

20200327_174500

┆Issue is synchronized with this Jira Task

@sflorean sflorean added the 🐞 bug Crashes, Something isn't working, .. label Mar 27, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 27, 2020
@abodea abodea added Feature:CustomTabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. and removed needs:triage Issue needs triage labels Mar 27, 2020
@Diana-Rus
Copy link

Hi, reproduce issue with Google Pixel 3 XL (Android 9) on Beta 4.3.0-beta.1 .

@sflorean
Copy link
Contributor Author

Reproducible also on 5.0.0-beta.1 - in normal browsing.

@ekager
Copy link
Contributor

ekager commented Jun 1, 2020

Not sure if this is the same issue but it looks like if a link opens in a new window while in a custom tab, then it looks like a new custom tab and the buttons are greyed out. Pressing the device back button "closes" the custom tab, but then takes you back to your original custom tab. It's definitely weird behavior.

So for example clicking into different articles on bbc.com -> all open in same custom tab window, back + forward buttons work.
Clicking an ad on bbc.com -> opens as a new tab, strange custom tab menu behavior.

Maybe the solution here is just to open all links in one tab for custom tabs since it's really supposed to be one window anyway and there's no way to tab switch.

@lobontiumira
Copy link

Reproducible on 79.0.0-beta.8 Beta build with Samsung Galaxy Tab S6 (Android 9).

@ekager ekager added the needs:ac Needs Android Component Work label Jul 17, 2020
@stale
Copy link

stale bot commented Feb 4, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 4, 2021
@stale stale bot closed this as completed Feb 11, 2021
@lobontiumira
Copy link

I will reopen this issue because I reproduced it on Beta 89.0.0-beta.1 with Samsung Galaxy Note 8 (Android 9).

@stale
Copy link

stale bot commented Oct 19, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 19, 2021
@stale stale bot closed this as completed Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:CustomTabs Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. needs:ac Needs Android Component Work S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist wontfix
Projects
None yet
Development

No branches or pull requests

5 participants