Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube theater mode not using full screen width #13232

Open
struq opened this issue Feb 14, 2023 · 5 comments
Open

Youtube theater mode not using full screen width #13232

struq opened this issue Feb 14, 2023 · 5 comments
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected

Comments

@struq
Copy link

struq commented Feb 14, 2023

Steps to reproduce

  1. Open any wide format video on Youtube, e.g. https://www.youtube.com/watch?v=6Y8FVIiWyao
  2. Click the "theater mode" button on the player toolbar (third button from the right)

Expected behavior

  1. The video always uses the full screen width, like in Safari and Chrome

Actual behavior

  1. Initially the video is not using the full width and there are black bars on the left and right.
  2. Only after scrolling down the page, the video is enlarged to the full width (and the resize process is not smooth)

Device & build information

  • Device: iPad Pro 10.5"
  • Build version: 109.0 (25841)
    1. Notes
      Attachments:
      youtubeUNITO-UNDERSCORE!firefox!
      youtubeUNITO-UNDERSCORE!safari!

┆Issue is synchronized with this Jira Task

@struq struq added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Feb 14, 2023
@dholbert
Copy link

This is a version of #11574 -- it looks like Firefox is dynamically resizing its viewport depending on the presence/absence of the dynamic toolbar. You can see this by visiting https://www.whatismybrowser.com/ and comparing the "Browser Window Size" between Firefox vs. Chrome/Safari (on iOS). For me on my iPad, Firefox reports 748px vs. Safari/Chrome report 768px (when I'm holding my tablet in landscape mode).

So the root issue here is that Firefox is using a shorter viewport here than Chrome and Safari (and then YouTube sees that the viewport is shorter and it makes the video a bit smaller, because they have some logic to ensure that the video plus a bit of the content that follows it is visible in the viewport-height-that-the-browser-reports-to-them).

@hiikezoe
Copy link

Given that the iOS version of Chrome can handle vh units properly, there should be APIs to tell the dynamic toolbar initial height to WebKit and tell the intermediate height to WebKit as well.

@lmarceau
Copy link
Contributor

Hello! Thanks for your input, I believe this relates to #11574 then.

Copy link
Contributor

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!

@github-actions github-actions bot added the stale Stalebot use this label to stale issues and PRs label Mar 18, 2024
@dholbert
Copy link

dholbert commented Mar 19, 2024

Still reproducible as-described in initial comment. (I just retested with current Firefox release vs. Safari, on my iPad.)

@github-actions github-actions bot removed the stale Stalebot use this label to stale issues and PRs label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected
Projects
None yet
Development

No branches or pull requests

4 participants