Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background push notifications showing messageIncoplete error #17315

Closed
skhamis opened this issue Nov 14, 2023 · 1 comment · Fixed by #17314
Closed

Background push notifications showing messageIncoplete error #17315

skhamis opened this issue Nov 14, 2023 · 1 comment · Fixed by #17314
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected

Comments

@skhamis
Copy link
Contributor

skhamis commented Nov 14, 2023

This regression was introduced in #17222 due to us moving the Viaduct initialization out of RustFirefoxAccounts which NotificationService was relying on.

Steps to reproduce

  1. Have firefox in the background
  2. Send a notification from another device

Expected behavior

  1. The push notification shows up with the sent tab (or signed in notification)

Actual behavior

image

Semi-related issue: #17313 (comment)
Related issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1864480

Device & build information

  • Device: ?
  • Build version: ?
  • First seen version: ?

Notes

Attachments:

┆Issue is synchronized with this Jira Task

@skhamis skhamis added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Nov 14, 2023
@cpeterso
Copy link

The first Firefox iOS build with this messageIncomplete error is build 9000 (35974). The previous build, 9000 (35936), correctly shows a notification with the sent URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants