Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links from external apps open Firefox but don't load the link (intermittent) #18033

Closed
davismtl opened this issue Jan 8, 2024 · 13 comments
Closed
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected

Comments

@davismtl
Copy link

davismtl commented Jan 8, 2024

Steps to reproduce

  • Click on a link in another app (e.g. email)
  • Firefox opens

Expected behavior

  • Link opens a new tab and loads

Actual behavior

  • Nothing. Loads the last viewed tab.
  • I need to click on the link a second time

Device & build information

  • Device: iPhone 15 Pro Max, 17.2.1
  • Build version: 122.0 (37367)
  • First seen version: I don't know.

Notes

  • It's hard to reproduce because it happens every so often but not enough to easily reproduce but then again often enough that it annoyed me over the holidays (and I could easily see how it could lead to browser churn).
  • It's not a new problem but it didn't happen often enough in the past for me to actually file a bug. It took 2 weeks of intense mobile usage to make the problem apparent.
  • A small observation (though anecdotal) is that I think it tends to happen more often when Firefox hasn't been used for some amount of time. I don't know if the OS put the app to sleep and it leads to this. But again there, it's not always doing this.
  • I've had this happen across multiple iPhones. (I had the iPhone 13 Pro prior to this one and it happened there too)
  • The tab doesn't seem to be opening in the background behind the last seen tab.

I'll try to start logging more detailed accounts of the situation. Are there any logs I can somehow get to that could help diagnose this?

┆Issue is synchronized with this Jira Task

@davismtl davismtl added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Jan 8, 2024
@brendanjones
Copy link

When trying to get a screen recording of #17927 I actually reproduced this one instead, so here’s a recording! I suspect they’re linked.

I don’t know the conditions that separate these two bugs, so I don’t know why sometimes the new page does/ doesn’t load.

Vid is too big to attach so here’s an iCloud link: https://share.icloud.com/photos/0d8AvYecQIrWxz4QIah-6JXNQ

What you’re seeing is:

  • video starts with me in Slack
  • I open the link in slack
  • Slack opens the link in its in-app browser
  • I tell it to open the link in my browser
  • Firefox opens, and the last tab I had open loads (the Kafka band event)
  • I go back to slack and open the link in browser again
  • Firefox loads, and correctly loads the link in a new tab.

@bholley
Copy link

bholley commented Jan 9, 2024

This recently started happening to me as well. I suspect it depends on whether Firefox is still running. Retrying generally works, which makes me suspect it's a similar type of failure to #17395.

@davismtl
Copy link
Author

It occurred first thing this morning again which somewhat aligns with my observation that it happens when Firefox has been idle for some time. It's been fine for the rest of the day.

I do see an updated release version so the app also updated overnight while charging so perhaps the app gets into a weird state after an update (which happens regularly with pre-release builds). This new hypothesis should be easier for me to test. I can try to do a manual update of the app at the next opportunity and see if I can replicate.

@davismtl
Copy link
Author

davismtl commented Jan 12, 2024

Circling back, I replicated it yesterday. I updated Firefox and the first link I clicked on didn't work. I had to click on it a second time to work. I'll try to replicate again with the next update.

@data-sync-user
Copy link
Collaborator

➤ Matthew Reagan commented:

I’m investigating this though I’ve not been able to replicate yet, and the requisite conditions causing the problem aren’t 100% clear. I did find a bug in the App Event Queue which could be related, so I am preparing a PR to address that; there is a chance that will fix the bug described in this ticket (8103) however I haven’t been able to confirm directly yet since I can’t replicate.

So far I’ve tested different scenarios including deeplinking while the app is backgrounded or after being jetsammed, forcing low-memory conditions, and also forcing the Start at Home feature to always trigger (to see if that was possibly causing a conflict with the tab loading). I’ve also got a device I’m letting sit idle to see if I can replicate after a long period of inactivity.

Sidenote: a few comments sound slightly similar to #17395 (FXIOS-7799) which should now be fixed but was a different issue that was 100% reproducible, and I don’t believe it’s related (that bug was occurring because the client simply wasn’t handling Sent Tab URLs which are routed differently when the app is killed vs. when the app is running or backgrounded).

Any additional screen recordings, logs, or repro steps would be helpful (cc Andrei Bodea Norberto Andres Furlan ).

@data-sync-user
Copy link
Collaborator

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v122 (37686), on iPhone 15 (17.0).

No external link loading issue encountered.

@data-sync-user
Copy link
Collaborator

➤ Norberto Andres Furlan commented:

Andrei Bodea Diana Andreea Barladeanu I have reports from people inside Firefox that says that it is still happening on 122.1. However, I am not able to reproduce it. Can you do more testing to see if still happening?

@zaipie
Copy link

zaipie commented Feb 7, 2024

I’ve also had this problem for a while now. Just happened again on Firefox 122.0, iPhone 14 Pro, iOS 17.2.1.
When: I opened a link from the Gmail app, which opened the Firefox app.
Expected: Firefox to display the linked page in a new tab.
Actual: Firefox displayed the last viewed tab, a page I opened yesterday.

Opening the link from gmail again does make Firefox open the link correctly and load the page in a new tab.

@data-sync-user
Copy link
Collaborator

➤ Matthew Reagan commented:

This is likely a duplicate of https://mozilla-hub.atlassian.net/browse/FXIOS-7799 ( https://mozilla-hub.atlassian.net/browse/FXIOS-7799|smart-link ) , even though that ticket specifically mentions Send to Device, I believe the underlying culprit is likely the same.

The issue is being actively investigated; I’ve been able to reproduce it a few times now and am gathering additional diagnostic information and will update on 7799 as soon as I’m able.

@Sobakel
Copy link

Sobakel commented Apr 7, 2024

This is still happening for me.
iPhone 15pro
Ios17.4
Firefox 124.2 (40108) set as default browser

in any app, I press hyperlink. Firefox opens but no link appears and no activity l. Second try does nothing. Have to copy and paste if possible.
Banking app opens Firefox when pressing privacy policy link but not link loads. Have to make Safari the default via settings in order for links that can’t be copied to open

@AkaZecik
Copy link

AkaZecik commented Apr 8, 2024

Happening for me as well, no matter if Firefox is already running in the background or not. Same symptoms as @Sobakel's and others'.

iPhone 8
iOS 16.7.7
Firefox 124.3 (40336) set as default browser

@BBreiden
Copy link

I do also experience this issue. For me all links from any app do not work anymore. Copying the URL and manually opening it works. I use Firefox as the default browser.

iPhone 12 Pro
iOS 17.4.1
Firefox 125.1 (40778)

@florianjehn
Copy link

I also experience this issue. The bug always occurs when I try to open a link with Firefox while Firefox is not open. As Firefox is my default browser, it opens, but does not load. Also when other tabs from previous sessions were open, I cannot view them, as Firefox tells me they have crashed. To use Firefox again I have to restart it. This happens on both my Laptop and my Desktop computer. Both use:

  • Linux (Zorin 17)
  • Firefox 127.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected
Projects
None yet
Development

No branches or pull requests

9 participants