-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Fonts related to Accessory view to use FXFontStyles #19805
Comments
➤ Cyndi Chin commented: After: See changes for following screens: !Simulator Screenshot - iPhone 15 - 2024-05-17 at 09.53.49.png|width=1179,height=2556,alt="Simulator Screenshot - iPhone 15 - 2024-05-17 at 09.53.49.png"! !Simulator Screenshot - iPhone 15 - 2024-05-17 at 09.52.35.png|width=1179,height=2556,alt="Simulator Screenshot - iPhone 15 - 2024-05-17 at 09.52.35.png"! See changes on the bottom view with “Use saved card”. Before: !Simulator Screenshot - iPhone 15 - 2024-05-17 at 09.56.32.png|width=1179,height=2556,alt="Simulator Screenshot - iPhone 15 - 2024-05-17 at 09.56.32.png"! !Simulator Screenshot - iPhone 15 - 2024-05-17 at 09.56.20.png|width=1179,height=2556,alt="Simulator Screenshot - iPhone 15 - 2024-05-17 at 09.56.20.png"! |
➤ Crystal Wong commented: Hi Cyndi Chin, thank you for providing the screenshots! Would like to make some adjustments. Will share below. Also, this will probably go in a different ticket, but I think(?) there is a typo under the first paragraph upon reading it, I’ve highlighted it in red. Should it be “what you do online” instead of “what do you online”? Thanks! !Changes.png|width=1434,height=1104,alt="Changes.png"! |
➤ Cyndi Chin commented: Thanks Crystal Wong ! Yes, I can create a new ticket to address that, thanks for the catch! |
The original PR opened for this ticket went stale, this issue is open to be worked on. Thank you! |
Hi @cyndichin, I would like to work on this issue. Thanks 🙏 |
thanks @bmihai23! assigned the ticket to you |
➤ Cyndi Chin commented: For QA, please verify fonts scale appropriately, see screenshots in PR. |
➤ Diana Andreea Barladeanu commented: Validated on v9000 (43906), with iPhone 15 (17.5). |
This task is part of a series of tasks to standardizing fonts to start using FXFontStyles.
Background Context:
Previously, we were using
DefaultDynamicFontHelper
and setting the text style, size and weight for each font, which sometimes did not match our design system. By usingFXFontStyles
, we can standardize our fonts and be more aligned with the design system.Task:
Please update how we set fonts in the Firefox iOS Project related:
AccessoryViewProvider
TPAccessoryInfo
AutofillAccessoryViewButtonItem
Acceptance Criteria:
Replace usage of
DefaultDynamicFontHelper
withFXFontStyles
If there are discrepancies in terms of replacing the old fonts with the new standard, we will need to bring design in to approve the PR.
Please provide before and after screenshots of the UI.
Reference:
Usage example:
FXFontStyles.Regular.headline.scaledFont()
See this PR for example of standardizing fonts for Primary Button:
https://github.com/mozilla-mobile/firefox-ios/pull/18711/files
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: