Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While in reading view, toggling night mode shows white bar under reading view settings #5917

Closed
SimonBasca opened this issue Dec 16, 2019 · 5 comments
Closed

While in reading view, toggling night mode shows white bar under reading view settings #5917

SimonBasca opened this issue Dec 16, 2019 · 5 comments
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor OK This is a good issue for contributors interested in helping the project P3 Issues that would be nice to have for the current release QA Verified Issue verified by QA
Projects
Firefox iOS Development

Comments

@SimonBasca
Copy link
Contributor

SimonBasca commented Dec 16, 2019 •
edited by data-sync-user

Build: 21.0 (16918)
Device: iPhone Xr
iOS: 13.2

Steps to reproduce:

  1. Navigate to a webpage that allows reader view (e.g. https://developer.mozilla.org/en-US/docs/Mozilla/An_introduction_to_hacking_Mozilla)
  2. Set reading view theme to dark or sepia
  3. Toggle night mode on or off 2 times or more (bug is more apparent if you land in night mode)

Actual results:

  • There is a white bar under the reader view settings.

Expected results:

  • No white bar should appear. The reader view should look just as it did when user first enabled reader view.

Screenshot:

  • image

Logged via: https://bugzilla.mozilla.org/show_bug.cgi?id=1602214

┆Issue is synchronized with this Jira Task
@SimonBasca SimonBasca added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Dec 16, 2019
@SimonBasca SimonBasca added this to Needs Triage in Firefox iOS Development via automation Dec 16, 2019
@athomasmoz athomasmoz added Contributor OK This is a good issue for contributors interested in helping the project P3 Issues that would be nice to have for the current release labels Jan 16, 2020
@project-bot project-bot bot moved this from Needs Triage to P3 Backlog in Firefox iOS Development Jan 16, 2020
@LamourBt
Copy link
Contributor

LamourBt commented Feb 12, 2020 •
edited

I took on the liberty to work on this ticket. if no one opposed.

@LamourBt LamourBt mentioned this issue Feb 13, 2020
Merged
@SimonBasca SimonBasca added the QA Verified Issue verified by QA label Feb 25, 2020
@SimonBasca
Copy link
Contributor Author

Verified as fix on master 9b3f393.

Firefox iOS Development automation moved this from P3 Backlog to Done Feb 25, 2020
@athomasmoz athomasmoz added this to the v24 milestone Feb 26, 2020
@garvankeeley
Copy link
Contributor

garvankeeley commented Mar 11, 2020 •
edited

Reverting the fix and re-opening.
(the fix caused 2 bugs, #6234, #6135 )

@garvankeeley garvankeeley reopened this Mar 11, 2020
@LamourBt
Copy link
Contributor

@garvankeeley I would want to take another stab at it you can add more description (if any)

@garvankeeley
Copy link
Contributor

Hi I don't have any suggestions on how to fix this unfortunately

@athomasmoz athomasmoz removed this from the v24 milestone May 4, 2020
@data-sync-user data-sync-user changed the title While in reading view, toggling night mode shows white bar under reading view settings FXIOS-208 ⁃ While in reading view, toggling night mode shows white bar under reading view settings Oct 16, 2020
@data-sync-user data-sync-user changed the title FXIOS-208 ⁃ While in reading view, toggling night mode shows white bar under reading view settings While in reading view, toggling night mode shows white bar under reading view settings Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor OK This is a good issue for contributors interested in helping the project P3 Issues that would be nice to have for the current release QA Verified Issue verified by QA
Projects
No open projects
Firefox iOS Development
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@garvankeeley @dnarcese @LamourBt @SimonBasca @athomasmoz