Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home "Custom URL" placeholder text is barely visible #6152

Closed
SimonBasca opened this issue Feb 24, 2020 · 2 comments · Fixed by #6169
Closed

Home "Custom URL" placeholder text is barely visible #6152

SimonBasca opened this issue Feb 24, 2020 · 2 comments · Fixed by #6169
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval Contributor OK This is a good issue for contributors interested in helping the project QA Verified Issue verified by QA
Projects
Firefox iOS Development

Comments

@SimonBasca
Copy link
Contributor

SimonBasca commented Feb 24, 2020 •
edited

Build: 23.0(17297)
Device: iPhone X
iOS: 13.3

Preconditions:

  • Set theme to Manual Light.
  • Set iOS theme to Dark.

Steps to reproduce:

  1. Go to Settings -> Home
  2. Check the "Custom URL" placeholder text

Actual results:

  • The placeholder text is barley visible.

Expected results:

  • The placeholder text should be visible.

Screen Shot 2020-02-24 at 2 00 24 PM
@SimonBasca SimonBasca added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Feb 24, 2020
@SimonBasca SimonBasca added this to Needs Triage in Firefox iOS Development via automation Feb 24, 2020
@SimonBasca SimonBasca changed the title Home "Custom URL" placeholder text is barley visible Home "Custom URL" placeholder text is barely visible Feb 24, 2020
@aaskrv
Copy link
Contributor

aaskrv commented Feb 28, 2020

Hi! Can you assign me to this? @SimonBasca

@dnarcese dnarcese added the Contributor OK This is a good issue for contributors interested in helping the project label Feb 28, 2020
@LamourBt LamourBt mentioned this issue Mar 2, 2020
Closed
@dnarcese dnarcese added the Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval label Mar 3, 2020
@dnarcese dnarcese linked a pull request Mar 3, 2020 that will close this issue
Fix6152 - Home 'Custom URL' placeholder text is barely visible #6169
Merged
Firefox iOS Development automation moved this from Needs Triage to Needs QA Mar 24, 2020
@csuciu
Copy link

csuciu commented Mar 26, 2020

Verified as fixed on master 5ba3e95. The text is displayed correctly.

@csuciu csuciu added the QA Verified Issue verified by QA label Mar 26, 2020
@project-bot project-bot bot moved this from Needs QA to Done in Firefox iOS Development Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval Contributor OK This is a good issue for contributors interested in helping the project QA Verified Issue verified by QA
Projects
No open projects
Firefox iOS Development
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix6152 - Home 'Custom URL' placeholder text is barely visible KrystynaKruchkovska/firefox-ios
4 participants
@csuciu @dnarcese @aaskrv @SimonBasca